Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 285323002: drive: Remove FileCache::GetCacheEntry (Closed)

Created:
6 years, 7 months ago by hashimoto
Modified:
6 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

drive: Remove FileCache::GetCacheEntry BUG=275271 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270952

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -222 lines) Patch
M chrome/browser/chromeos/drive/file_cache.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 11 chunks +25 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 3 chunks +6 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 6 chunks +14 lines, -70 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 6 chunks +32 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
6 years, 7 months ago (2014-05-15 08:08:31 UTC) #1
kinaba
lgtm
6 years, 7 months ago (2014-05-16 04:47:54 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 7 months ago (2014-05-16 04:53:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/285323002/20001
6 years, 7 months ago (2014-05-16 04:53:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 05:50:43 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 06:57:18 UTC) #6
Message was sent while issue was closed.
Change committed as 270952

Powered by Google App Engine
This is Rietveld 408576698