Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc

Issue 285323002: drive: Remove FileCache::GetCacheEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc
diff --git a/chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc b/chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc
index 241294c626bdfe869f3836b7c36237d119e0cb1c..6481cb3eae8483cc659e603d1ccd30351cac78b0 100644
--- a/chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc
+++ b/chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc
@@ -235,18 +235,9 @@ TEST_F(EntryUpdatePerformerTest, UpdateEntry_ContentUpdate) {
server_entry->file_size());
// Make sure that the cache is no longer dirty.
- FileCacheEntry cache_entry;
- base::PostTaskAndReplyWithResult(
- blocking_task_runner(),
- FROM_HERE,
- base::Bind(&FileCache::GetCacheEntry,
- base::Unretained(cache()),
- local_id,
- &cache_entry),
- google_apis::test_util::CreateCopyResultCallback(&error));
- test_util::RunBlockingPoolTask();
- ASSERT_EQ(FILE_ERROR_OK, error);
- EXPECT_FALSE(cache_entry.is_dirty());
+ ResourceEntry entry;
+ EXPECT_EQ(FILE_ERROR_OK, GetLocalResourceEntry(kFilePath, &entry));
+ EXPECT_FALSE(entry.file_specific_info().cache_state().is_dirty());
}
TEST_F(EntryUpdatePerformerTest, UpdateEntry_ContentUpdateMd5Check) {
@@ -288,18 +279,9 @@ TEST_F(EntryUpdatePerformerTest, UpdateEntry_ContentUpdateMd5Check) {
server_entry->file_size());
// Make sure that the cache is no longer dirty.
- FileCacheEntry cache_entry;
- base::PostTaskAndReplyWithResult(
- blocking_task_runner(),
- FROM_HERE,
- base::Bind(&FileCache::GetCacheEntry,
- base::Unretained(cache()),
- local_id,
- &cache_entry),
- google_apis::test_util::CreateCopyResultCallback(&error));
- test_util::RunBlockingPoolTask();
- ASSERT_EQ(FILE_ERROR_OK, error);
- EXPECT_FALSE(cache_entry.is_dirty());
+ ResourceEntry entry;
+ EXPECT_EQ(FILE_ERROR_OK, GetLocalResourceEntry(kFilePath, &entry));
+ EXPECT_FALSE(entry.file_specific_info().cache_state().is_dirty());
// Again mark the cache file dirty.
scoped_ptr<base::ScopedClosureRunner> file_closer;
@@ -332,17 +314,8 @@ TEST_F(EntryUpdatePerformerTest, UpdateEntry_ContentUpdateMd5Check) {
fake_service()->about_resource().largest_change_id());
// Make sure that the cache is no longer dirty.
- base::PostTaskAndReplyWithResult(
- blocking_task_runner(),
- FROM_HERE,
- base::Bind(&FileCache::GetCacheEntry,
- base::Unretained(cache()),
- local_id,
- &cache_entry),
- google_apis::test_util::CreateCopyResultCallback(&error));
- test_util::RunBlockingPoolTask();
- ASSERT_EQ(FILE_ERROR_OK, error);
- EXPECT_FALSE(cache_entry.is_dirty());
+ EXPECT_EQ(FILE_ERROR_OK, GetLocalResourceEntry(kFilePath, &entry));
+ EXPECT_FALSE(entry.file_specific_info().cache_state().is_dirty());
}
TEST_F(EntryUpdatePerformerTest, UpdateEntry_OpenedForWrite) {
@@ -379,18 +352,9 @@ TEST_F(EntryUpdatePerformerTest, UpdateEntry_OpenedForWrite) {
EXPECT_EQ(FILE_ERROR_OK, error);
// Make sure that the cache is still dirty.
- FileCacheEntry cache_entry;
- base::PostTaskAndReplyWithResult(
- blocking_task_runner(),
- FROM_HERE,
- base::Bind(&FileCache::GetCacheEntry,
- base::Unretained(cache()),
- local_id,
- &cache_entry),
- google_apis::test_util::CreateCopyResultCallback(&error));
- test_util::RunBlockingPoolTask();
- EXPECT_EQ(FILE_ERROR_OK, error);
- EXPECT_TRUE(cache_entry.is_dirty());
+ ResourceEntry entry;
+ EXPECT_EQ(FILE_ERROR_OK, GetLocalResourceEntry(kFilePath, &entry));
+ EXPECT_TRUE(entry.file_specific_info().cache_state().is_dirty());
// Close the file.
file_closer.reset();
@@ -405,17 +369,8 @@ TEST_F(EntryUpdatePerformerTest, UpdateEntry_OpenedForWrite) {
EXPECT_EQ(FILE_ERROR_OK, error);
// Make sure that the cache is no longer dirty.
- base::PostTaskAndReplyWithResult(
- blocking_task_runner(),
- FROM_HERE,
- base::Bind(&FileCache::GetCacheEntry,
- base::Unretained(cache()),
- local_id,
- &cache_entry),
- google_apis::test_util::CreateCopyResultCallback(&error));
- test_util::RunBlockingPoolTask();
- EXPECT_EQ(FILE_ERROR_OK, error);
- EXPECT_FALSE(cache_entry.is_dirty());
+ EXPECT_EQ(FILE_ERROR_OK, GetLocalResourceEntry(kFilePath, &entry));
+ EXPECT_FALSE(entry.file_specific_info().cache_state().is_dirty());
}
TEST_F(EntryUpdatePerformerTest, UpdateEntry_UploadNewFile) {
@@ -459,18 +414,7 @@ TEST_F(EntryUpdatePerformerTest, UpdateEntry_UploadNewFile) {
EXPECT_EQ(ResourceEntry::CLEAN, entry.metadata_edit_state());
// Make sure that the cache is no longer dirty.
- FileCacheEntry cache_entry;
- base::PostTaskAndReplyWithResult(
- blocking_task_runner(),
- FROM_HERE,
- base::Bind(&FileCache::GetCacheEntry,
- base::Unretained(cache()),
- local_id,
- &cache_entry),
- google_apis::test_util::CreateCopyResultCallback(&error));
- test_util::RunBlockingPoolTask();
- EXPECT_EQ(FILE_ERROR_OK, error);
- EXPECT_FALSE(cache_entry.is_dirty());
+ EXPECT_FALSE(entry.file_specific_info().cache_state().is_dirty());
// Make sure that we really created a file.
google_apis::GDataErrorCode status = google_apis::GDATA_OTHER_ERROR;
« no previous file with comments | « chrome/browser/chromeos/drive/sync/entry_update_performer.cc ('k') | chrome/browser/chromeos/drive/sync_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698