Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2853153002: Disabled a few more failing perf tests (Closed)

Created:
3 years, 7 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled a few more failing perf tests These have been failing for quite a while. BUG=717314, 717309, 717300 Review-Url: https://codereview.chromium.org/2853153002 Cr-Commit-Position: refs/heads/master@{#468614} Committed: https://chromium.googlesource.com/chromium/src/+/593fd07de697fbef76e5d7a878546f66118a53b7

Patch Set 1 #

Patch Set 2 : removed unintentional change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M ios/chrome/browser/ui/ntp/new_tab_page_perftest.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/omnibox_perftest.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
pkl (ping after 24h if needed)
perftests seem to be rotting.
3 years, 7 months ago (2017-05-02 00:03:14 UTC) #2
baxley
Thanks! LGTM
3 years, 7 months ago (2017-05-02 00:33:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853153002/20001
3 years, 7 months ago (2017-05-02 00:40:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/424913)
3 years, 7 months ago (2017-05-02 00:52:22 UTC) #7
pkl (ping after 24h if needed)
+rohitrao +marq for OWNERS
3 years, 7 months ago (2017-05-02 01:21:07 UTC) #9
sczs
LGTM Thanks for doing this, I actually thought that the perf waterfall was always flaky.
3 years, 7 months ago (2017-05-02 01:27:24 UTC) #10
marq (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-02 11:12:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853153002/20001
3 years, 7 months ago (2017-05-02 13:05:14 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 13:09:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/593fd07de697fbef76e5d7a87854...

Powered by Google App Engine
This is Rietveld 408576698