MacViews: Allows the toolkit-views Device Chooser bubble to be used

chrome/browser/ui/BUILD.gn

Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 17193bdd88c6563f5911255fbfd8b26a355fdcdd..a4907cc763d846bfe94f36325c51a98f21464b1b 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -1583,6 +1583,8 @@ split_static_library("ui") {
       "views/payments/validation_delegate.h",
       "views/payments/view_stack.cc",
       "views/payments/view_stack.h",
+      "views/permission_bubble/chooser_bubble_ui_view.cc",
+      "views/permission_bubble/chooser_bubble_ui_view.h",
       "views/permission_bubble/permission_prompt_impl.cc",
       "views/permission_bubble/permission_prompt_impl.h",
       "views/subtle_notification_view.cc",
@@ -1627,6 +1629,7 @@ split_static_library("ui") {
         "views/frame/opaque_browser_frame_view_linux.h",
         "views/frame/opaque_browser_frame_view_platform_specific.cc",
         "views/frame/opaque_browser_frame_view_platform_specific.h",
+        "views/permission_bubble/chooser_bubble_ui_view_views.cc",

[tapted, 2017/05/03 05:23:09]

This won't be compiled on ChromeOS 

(also perhaps chooser_bubble_ui_impl_views.cc )

[varkha, 2017/05/03 08:47:03]

Done.

         "views/profiles/profile_chooser_view.cc",
         "views/profiles/profile_chooser_view.h",
         "views/screen_capture_notification_ui_views.cc",
@@ -1842,8 +1845,6 @@ split_static_library("ui") {
         "views/outdated_upgrade_bubble_view.h",
         "views/passwords/manage_passwords_icon_views.cc",
         "views/passwords/manage_passwords_icon_views.h",
-        "views/permission_bubble/chooser_bubble_ui_view.cc",
-        "views/permission_bubble/chooser_bubble_ui_view.h",
         "views/permission_bubble/permission_prompt_impl_views.cc",

[tapted, 2017/05/03 05:23:09]

chooser_bubble_ui_view_views.cc -> chooser_bubble_ui_impl_views.cc should go
here, above this line

[varkha, 2017/05/03 08:47:03]

Done.

         "views/process_singleton_dialog_linux.cc",
         "views/profiles/profile_indicator_icon.cc",
@@ -2925,6 +2926,7 @@ split_static_library("ui") {
         "cocoa/passwords/update_pending_password_view_controller.mm",
         "cocoa/permission_bubble/chooser_bubble_ui_cocoa.h",
         "cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm",
+        "cocoa/permission_bubble/chooser_bubble_ui_view_cocoa_views.mm",

[tapted, 2017/05/03 05:23:09]

perhaps chooser_bubble_ui_impl_views_mac.mm (in keeping with
permission_prompt_impl_views_mac.mm)

[varkha, 2017/05/03 08:47:03]

Done (keeping the style and shortening).

         "cocoa/permission_bubble/permission_bubble_cocoa.h",
         "cocoa/permission_bubble/permission_bubble_cocoa.mm",
         "cocoa/permission_bubble/permission_bubble_controller.h",