MacViews: Allows the toolkit-views Device Chooser bubble to be used

chrome/browser/ui/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 1565 matching lines @@
       "views/payments/shipping_address_editor_view_controller.h",
       "views/payments/shipping_option_view_controller.cc",
       "views/payments/shipping_option_view_controller.h",
       "views/payments/validating_combobox.cc",
       "views/payments/validating_combobox.h",
       "views/payments/validating_textfield.cc",
       "views/payments/validating_textfield.h",
       "views/payments/validation_delegate.h",
       "views/payments/view_stack.cc",
       "views/payments/view_stack.h",
+      "views/permission_bubble/chooser_bubble_ui_view.cc",
+      "views/permission_bubble/chooser_bubble_ui_view.h",
       "views/permission_bubble/permission_prompt_impl.cc",
       "views/permission_bubble/permission_prompt_impl.h",
       "views/subtle_notification_view.cc",
       "views/subtle_notification_view.h",
       "views/sync/bubble_sync_promo_view.cc",
       "views/sync/bubble_sync_promo_view.h",
       "views/sync/profile_signin_confirmation_dialog_views.cc",
       "views/sync/profile_signin_confirmation_dialog_views.h",
       "views/task_manager_view.cc",
       "views/task_manager_view.h",
@@ skipping 24 matching lines @@
       sources += [
         "views/frame/opaque_browser_frame_view.cc",
         "views/frame/opaque_browser_frame_view.h",
         "views/frame/opaque_browser_frame_view_layout.cc",
         "views/frame/opaque_browser_frame_view_layout.h",
         "views/frame/opaque_browser_frame_view_layout_delegate.h",
         "views/frame/opaque_browser_frame_view_linux.cc",
         "views/frame/opaque_browser_frame_view_linux.h",
         "views/frame/opaque_browser_frame_view_platform_specific.cc",
         "views/frame/opaque_browser_frame_view_platform_specific.h",
+        "views/permission_bubble/chooser_bubble_ui_view_views.cc",

[tapted, 2017/05/03 05:23:09]

This won't be compiled on ChromeOS 

(also perhaps chooser_bubble_ui_impl_views.cc )

[varkha, 2017/05/03 08:47:03]

Done.

         "views/profiles/profile_chooser_view.cc",
         "views/profiles/profile_chooser_view.h",
         "views/screen_capture_notification_ui_views.cc",
         "views/sync/one_click_signin_dialog_view.cc",
         "views/sync/one_click_signin_dialog_view.h",
       ]
     }
 
     # These files do Gtk+-based theming, but Gtk+ is not available on
     # Ozone builds, or on common environments where Ozone will be used.
@@ skipping 195 matching lines @@
         "views/omnibox/omnibox_popup_contents_view.cc",
         "views/omnibox/omnibox_popup_contents_view.h",
         "views/omnibox/omnibox_result_view.cc",
         "views/omnibox/omnibox_result_view.h",
         "views/omnibox/omnibox_view_views.cc",
         "views/omnibox/omnibox_view_views.h",
         "views/outdated_upgrade_bubble_view.cc",
         "views/outdated_upgrade_bubble_view.h",
         "views/passwords/manage_passwords_icon_views.cc",
         "views/passwords/manage_passwords_icon_views.h",
-        "views/permission_bubble/chooser_bubble_ui_view.cc",
-        "views/permission_bubble/chooser_bubble_ui_view.h",
         "views/permission_bubble/permission_prompt_impl_views.cc",

[tapted, 2017/05/03 05:23:09]

chooser_bubble_ui_view_views.cc -> chooser_bubble_ui_impl_views.cc should go
here, above this line

[varkha, 2017/05/03 08:47:03]

Done.

         "views/process_singleton_dialog_linux.cc",
         "views/profiles/profile_indicator_icon.cc",
         "views/profiles/profile_indicator_icon.h",
         "views/profiles/user_manager_view.cc",
         "views/profiles/user_manager_view.h",
         "views/proximity_auth/proximity_auth_error_bubble_view.cc",
         "views/proximity_auth/proximity_auth_error_bubble_view.h",
         "views/session_crashed_bubble_view.cc",
         "views/session_crashed_bubble_view.h",
         "views/simple_message_box_views.cc",
@@ skipping 1060 matching lines @@
         "cocoa/passwords/pending_password_view_controller.h",
         "cocoa/passwords/pending_password_view_controller.mm",
         "cocoa/passwords/save_pending_password_view_controller.h",
         "cocoa/passwords/save_pending_password_view_controller.mm",
         "cocoa/passwords/signin_promo_view_controller.h",
         "cocoa/passwords/signin_promo_view_controller.mm",
         "cocoa/passwords/update_pending_password_view_controller.h",
         "cocoa/passwords/update_pending_password_view_controller.mm",
         "cocoa/permission_bubble/chooser_bubble_ui_cocoa.h",
         "cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm",
+        "cocoa/permission_bubble/chooser_bubble_ui_view_cocoa_views.mm",

[tapted, 2017/05/03 05:23:09]

perhaps chooser_bubble_ui_impl_views_mac.mm (in keeping with
permission_prompt_impl_views_mac.mm)

[varkha, 2017/05/03 08:47:03]

Done (keeping the style and shortening).

         "cocoa/permission_bubble/permission_bubble_cocoa.h",
         "cocoa/permission_bubble/permission_bubble_cocoa.mm",
         "cocoa/permission_bubble/permission_bubble_controller.h",
         "cocoa/permission_bubble/permission_bubble_controller.mm",
         "cocoa/permission_bubble/permission_prompt_impl_views_mac.mm",
         "cocoa/profiles/avatar_base_controller.h",
         "cocoa/profiles/avatar_base_controller.mm",
         "cocoa/profiles/avatar_button.h",
         "cocoa/profiles/avatar_button.mm",
         "cocoa/profiles/avatar_button_controller.h",
@@ skipping 646 matching lines @@
       "test/test_confirm_bubble_model.cc",
       "test/test_confirm_bubble_model.h",
     ]
     deps += [ "//chrome/test:test_support_ui" ]
   }
 
   if (enable_extensions) {
     deps += [ "//extensions/browser" ]
   }
 }