Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2853123003:
EME contentType checks for AC3/EAC3 (Closed)
|
Created:
3 years, 7 months ago by yucliu1 Modified:
3 years, 7 months ago CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, eme-reviews_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEME contentType checks for AC3/EAC3
Add missed EME contentType checks for 'ac-3', 'ec-3'
Bug: 710167
Test: Test on Cast, Cast for Android
Review-Url: https://codereview.chromium.org/2853123003
Cr-Commit-Position: refs/heads/master@{#468715}
Committed: https://chromium.googlesource.com/chromium/src/+/7d30cf67b1bd1b78cc95ef9ad88f421bc9bc01f4
Patch Set 1 #Patch Set 2 : nit #Patch Set 3 : Fix unit test #Patch Set 4 : Fix type #Patch Set 5 : int32 #
Messages
Total messages: 37 (25 generated)
The CQ bit was checked by yucliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yucliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== EME contentType checks for AC3/EAC3 Add missed EME contentType checks for 'ac-3', 'ec-3' Bug: 710167 Test: Test on Cast, Cast for Android ========== to ========== EME contentType checks for AC3/EAC3 Add missed EME contentType checks for 'ac-3', 'ec-3' Bug: 710167 Test: Test on Cast, Cast for Android ==========
yucliu@chromium.org changed reviewers: + chcunningham@chromium.org, servolk@chromium.org, slan@chromium.org, xhwang@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by yucliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
On 2017/05/01 22:11:23, yucliu1 wrote: Mostly looking good, but there's a compile error on Windows trybots, please fix it.
The CQ bit was checked by yucliu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by yucliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by yucliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/01 23:38:02, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. Pass CQ dry run, please take another review~
lgtm
lgtm
On 2017/05/02 16:45:34, xhwang_slow wrote: > lgtm lgtm
RS lgtm. (defer to xhwang)
On 2017/05/02 18:07:44, chcunningham wrote: > RS lgtm. (defer to xhwang) xhwang@ already l-g-t-m. I'll merge the diff.
The CQ bit was checked by yucliu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493749706567590,
"parent_rev": "5bc140b118c615e92e0393d8baf846d1a9bcbdba", "commit_rev":
"7d30cf67b1bd1b78cc95ef9ad88f421bc9bc01f4"}
Message was sent while issue was closed.
Description was changed from ========== EME contentType checks for AC3/EAC3 Add missed EME contentType checks for 'ac-3', 'ec-3' Bug: 710167 Test: Test on Cast, Cast for Android ========== to ========== EME contentType checks for AC3/EAC3 Add missed EME contentType checks for 'ac-3', 'ec-3' Bug: 710167 Test: Test on Cast, Cast for Android Review-Url: https://codereview.chromium.org/2853123003 Cr-Commit-Position: refs/heads/master@{#468715} Committed: https://chromium.googlesource.com/chromium/src/+/7d30cf67b1bd1b78cc95ef9ad88f... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/7d30cf67b1bd1b78cc95ef9ad88f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
