Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2853113003: Add COMPONENT to worker-dev OWNERS files for tests (Closed)

Created:
3 years, 7 months ago by falken
Modified:
3 years, 7 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, abarth-chromium, kinuko+worker_chromium.org, kinuko+serviceworker, shimazu+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add COMPONENT to worker-dev OWNERS files for tests BUG=679905 Review-Url: https://codereview.chromium.org/2853113003 Cr-Commit-Position: refs/heads/master@{#468536} Committed: https://chromium.googlesource.com/chromium/src/+/a211b69a97afb4efdad3420cf5ae97412946d55d

Patch Set 1 #

Total comments: 1

Patch Set 2 : worker-dev #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/workers/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/cachestorage/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/local/serviceworker/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
falken
3 years, 7 months ago (2017-05-01 23:57:38 UTC) #2
nhiroki
lgtm with one request :) https://codereview.chromium.org/2853113003/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2853113003/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode392 third_party/WebKit/LayoutTests/W3CImportExpectations:392: ## Owners: nhiroki@chromium.org Can ...
3 years, 7 months ago (2017-05-02 00:57:48 UTC) #6
falken
Thanks, done.
3 years, 7 months ago (2017-05-02 01:00:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853113003/20001
3 years, 7 months ago (2017-05-02 01:02:18 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 02:21:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a211b69a97afb4efdad3420cf5ae...

Powered by Google App Engine
This is Rietveld 408576698