Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3422)

Unified Diff: build/vs_toolchain.py

Issue 2853083002: Improve error message when debuggers not installed (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/vs_toolchain.py
diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py
index 8c7d6b99b01a04d787715fea12fca6fa42d118e1..b499255290b2f336a2e5118fe01c5ee457cb8513 100755
--- a/build/vs_toolchain.py
+++ b/build/vs_toolchain.py
@@ -325,6 +325,10 @@ def _CopyDebugger(target_dir, target_cpu):
debug_file = 'dbghelp.dll'
full_path = os.path.join(win_sdk_dir, 'Debuggers', target_cpu, debug_file)
+ if not os.path.exists(full_path):
+ raise Exception('dbghelp.dll not found in "%s"\r\nYou must install the '
+ '"Debugging Tools for Windows" feature from the Windows '
+ '10 SDK.' % full_path)
wkorman 2017/05/01 18:40:19 Is there a page worth linking to directly? I found
target_path = os.path.join(target_dir, debug_file)
_CopyRuntimeImpl(target_path, full_path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698