DevTools: clicking in console messages should not jump to bottom

DevTools: clicking in console messages should not jump to bottom

ConsolePrompt's moveCaretToEndOfPrompt() works by setting the CodeMirror
editor's selection to the end. After a recent CodeMirror roll, doing so now
scrolls the editor into view.

This change in behavior led to an error where expanding an object in console
would jump the viewport to bottom. This CL only focuses the prompt without
moving the cursor, in some cases.

NOTRY=true
NOPRESUBMIT=true
BUG=706128
Review-Url: https://codereview.chromium.org/2840663002
Cr-Commit-Position: refs/heads/master@{#468009}
(cherry picked from commit c5213f9bd6b6e6e95f40852b56ef62f1307c94ee)

Review-Url: https://codereview.chromium.org/2853053002
Cr-Commit-Position: refs/branch-heads/3071@{#331}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/0eefdccfe7b90d093875ebda910a72fbb182b6b8

[luoe, 2017-05-01 17:56:58]

Description was changed from

==========
DevTools: clicking in console messages should not jump to bottom

ConsolePrompt's moveCaretToEndOfPrompt() works by setting the CodeMirror
editor's selection to the end. After a recent CodeMirror roll, doing so now
scrolls the editor into view.

This change in behavior led to an error where expanding an object in console
would jump the viewport to bottom. This CL only focuses the prompt without
moving the cursor, in some cases.

BUG=706128

Review-Url: https://codereview.chromium.org/2840663002
Cr-Commit-Position: refs/heads/master@{#468009}
(cherry picked from commit c5213f9bd6b6e6e95f40852b56ef62f1307c94ee)
==========

to

==========
DevTools: clicking in console messages should not jump to bottom

ConsolePrompt's moveCaretToEndOfPrompt() works by setting the CodeMirror
editor's selection to the end. After a recent CodeMirror roll, doing so now
scrolls the editor into view.

This change in behavior led to an error where expanding an object in console
would jump the viewport to bottom. This CL only focuses the prompt without
moving the cursor, in some cases.

NOTRY=true
NOPRESUBMIT=true
BUG=706128

Review-Url: https://codereview.chromium.org/2840663002
Cr-Commit-Position: refs/heads/master@{#468009}
(cherry picked from commit c5213f9bd6b6e6e95f40852b56ef62f1307c94ee)
==========

[luoe, 2017-05-01 17:57:30]

luoe@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[luoe, 2017-05-01 17:57:30]

This is a merge to M59, no conflicts.  Needs a committer's lgtm to land.  Please
take a look

[kozy, 2017-05-01 18:38:05]

lgtm

[kozy, 2017-05-01 18:38:24]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-05-01 18:39:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:40:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493663904004550, "parent_rev":
"a1a28b7563d27518c747ce4e72ebd6193902adb4", "commit_rev":
"0eefdccfe7b90d093875ebda910a72fbb182b6b8"}

[commit-bot: I haz the power, 2017-05-01 18:40:16]

Description was changed from

==========
DevTools: clicking in console messages should not jump to bottom

ConsolePrompt's moveCaretToEndOfPrompt() works by setting the CodeMirror
editor's selection to the end. After a recent CodeMirror roll, doing so now
scrolls the editor into view.

This change in behavior led to an error where expanding an object in console
would jump the viewport to bottom. This CL only focuses the prompt without
moving the cursor, in some cases.

NOTRY=true
NOPRESUBMIT=true
BUG=706128

Review-Url: https://codereview.chromium.org/2840663002
Cr-Commit-Position: refs/heads/master@{#468009}
(cherry picked from commit c5213f9bd6b6e6e95f40852b56ef62f1307c94ee)
==========

to

==========
DevTools: clicking in console messages should not jump to bottom

ConsolePrompt's moveCaretToEndOfPrompt() works by setting the CodeMirror
editor's selection to the end. After a recent CodeMirror roll, doing so now
scrolls the editor into view.

This change in behavior led to an error where expanding an object in console
would jump the viewport to bottom. This CL only focuses the prompt without
moving the cursor, in some cases.

NOTRY=true
NOPRESUBMIT=true
BUG=706128

Review-Url: https://codereview.chromium.org/2840663002
Cr-Commit-Position: refs/heads/master@{#468009}
(cherry picked from commit c5213f9bd6b6e6e95f40852b56ef62f1307c94ee)

Review-Url: https://codereview.chromium.org/2853053002
Cr-Commit-Position: refs/branch-heads/3071@{#331}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/0eefdccfe7b90d093875ebda910a...
==========

[commit-bot: I haz the power, 2017-05-01 18:40:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0eefdccfe7b90d093875ebda910a...