Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 2853013003: Don't call UpdateFromLayout from StyleDidChange. (Closed)

Created:
3 years, 7 months ago by szager1
Modified:
3 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't call UpdateScrollingAfterLayout from StyleDidChange. This line was mistakenly added in: https://codereview.chromium.org/2839183002/ BUG=717099 Review-Url: https://codereview.chromium.org/2853013003 Cr-Commit-Position: refs/heads/master@{#468444} Committed: https://chromium.googlesource.com/chromium/src/+/43d8b52c651ff0086468f5c89235bac5f14cda0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
szager1
This is a blocker for tomorrow's dev release; if it looks good to you, please ...
3 years, 7 months ago (2017-05-01 21:16:40 UTC) #5
eae
LGTM
3 years, 7 months ago (2017-05-01 22:02:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853013003/1
3 years, 7 months ago (2017-05-01 22:03:34 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:09:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43d8b52c651ff0086468f5c89235...

Powered by Google App Engine
This is Rietveld 408576698