Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2853003003: [Android] Keep extracted secondary dex files when clearing data in tests. (RELAND) (Closed)

Created:
3 years, 7 months ago by jbudorick
Modified:
3 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Keep extracted secondary dex files when clearing data in tests. (RELAND) BUG=716029 Review-Url: https://codereview.chromium.org/2853003003 Cr-Commit-Position: refs/heads/master@{#468728} Committed: https://chromium.googlesource.com/chromium/src/+/73357e2349014d7638b891070dc5d557e78f87fa

Patch Set 1 : original #

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseChromiumRunnerCommon.java View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/main_dex_classes.flags View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/test/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java View 1 3 chunks +20 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jbudorick
3 years, 7 months ago (2017-05-02 17:31:53 UTC) #2
agrieve
On 2017/05/02 17:31:53, jbudorick wrote: lgtm
3 years, 7 months ago (2017-05-02 18:26:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853003003/20001
3 years, 7 months ago (2017-05-02 18:52:44 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 18:59:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73357e2349014d7638b891070dc5...

Powered by Google App Engine
This is Rietveld 408576698