[simulator] Make reference redirection thread-safe.

[simulator] Make reference redirection thread-safe.

In the simulators, the ExternalReference constructor rewrites external
addresses, which involves mutating a linked list rooted in the isolate.

We already construct external references concurrently (at least in Turbofan),
but the list mutation was not thread-safe (though no crashes are known). This
CL adds the necessary locking.

BUG=v8:6048
Review-Url: https://codereview.chromium.org/2852983002
Cr-Commit-Position: refs/heads/master@{#45014}
Committed: https://chromium.googlesource.com/v8/v8/+/34e7945647f6d2607a3d5446f483240b128e86c4

[neis, 2017-05-01 10:12:43]

Description was changed from

==========
[simulator] Make reference redirection thread-safe.

In the simulators, the ExternalReference constructor rewrites external
addresses, which involves mutating a linked list rooted in the isolate.

We already construct external references concurrently (at least in Turbofan),
but the list mutation was not thread-safe (though no crashes are known). This
CL adds the necessary locking.

BUG=
==========

to

==========
[simulator] Make reference redirection thread-safe.

In the simulators, the ExternalReference constructor rewrites external
addresses, which involves mutating a linked list rooted in the isolate.

We already construct external references concurrently (at least in Turbofan),
but the list mutation was not thread-safe (though no crashes are known). This
CL adds the necessary locking.

BUG=v8:6048
==========

[neis, 2017-05-01 10:12:51]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 10:12:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 10:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 10:42:23]

Dry run: This issue passed the CQ dry run.

[neis, 2017-05-01 17:30:18]

neis@chromium.org changed reviewers:
+ jarin@chromium.org

[neis, 2017-05-01 17:30:18]

PTAL.

[Jarin, 2017-05-02 09:06:11]

lgtm, thanks!

[neis, 2017-05-02 09:08:20]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2017-05-02 09:08:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 09:11:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493716100117500, "parent_rev":
"8f4e8c0aee2154d0a18e5e578871e716a1cb26c9", "commit_rev":
"34e7945647f6d2607a3d5446f483240b128e86c4"}

[commit-bot: I haz the power, 2017-05-02 09:11:53]

Description was changed from

==========
[simulator] Make reference redirection thread-safe.

In the simulators, the ExternalReference constructor rewrites external
addresses, which involves mutating a linked list rooted in the isolate.

We already construct external references concurrently (at least in Turbofan),
but the list mutation was not thread-safe (though no crashes are known). This
CL adds the necessary locking.

BUG=v8:6048
==========

to

==========
[simulator] Make reference redirection thread-safe.

In the simulators, the ExternalReference constructor rewrites external
addresses, which involves mutating a linked list rooted in the isolate.

We already construct external references concurrently (at least in Turbofan),
but the list mutation was not thread-safe (though no crashes are known). This
CL adds the necessary locking.

BUG=v8:6048

Review-Url: https://codereview.chromium.org/2852983002
Cr-Commit-Position: refs/heads/master@{#45014}
Committed:
https://chromium.googlesource.com/v8/v8/+/34e7945647f6d2607a3d5446f483240b128...
==========

[commit-bot: I haz the power, 2017-05-02 09:11:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/34e7945647f6d2607a3d5446f483240b128...