Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 285293007: Fix layoutOverflowRect in case of explicit 'overflow: scroll', but no overflow content (Closed)

Created:
6 years, 7 months ago by pals
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix layoutOverflowRect in case of explicit 'overflow: scroll', but no overflow content. BUG=371359 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174808

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : Fixed review comments #

Patch Set 4 : #

Patch Set 5 : platform-independent-layouttest #

Patch Set 6 : NeedsRebaselining for MAC #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -26 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/block/float/026-expected.txt View 1 2 3 4 5 6 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/platform/win/fast/block/float/028-expected.txt View 1 2 3 4 5 6 1 chunk +10 lines, -10 lines 0 comments Download
A LayoutTests/scrollbars/rtl/overflow-scroll-rtl.html View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/scrollbars/rtl/overflow-scroll-rtl-expected.png View 1 2 3 4 Binary file 0 comments Download
A LayoutTests/scrollbars/rtl/overflow-scroll-rtl-expected.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
pals
The changes in RenderBox.cpp fixes the layoutOverflowRect initialization if there is no overflow content. If ...
6 years, 7 months ago (2014-05-16 12:42:16 UTC) #1
Julien - ping for review
+Levi for the RenderBlockLineLayout which I think is fine but would need an expert check. ...
6 years, 7 months ago (2014-05-19 14:36:18 UTC) #2
pals
Using mock scrollbars but still the pixel test becomes platform dependent. Am I doing it ...
6 years, 7 months ago (2014-05-20 09:20:19 UTC) #3
Julien - ping for review
lgtm https://codereview.chromium.org/285293007/diff/10001/LayoutTests/scrollbars/rtl/overflow-scroll-rtl.html File LayoutTests/scrollbars/rtl/overflow-scroll-rtl.html (right): https://codereview.chromium.org/285293007/diff/10001/LayoutTests/scrollbars/rtl/overflow-scroll-rtl.html#newcode2 LayoutTests/scrollbars/rtl/overflow-scroll-rtl.html:2: <p>All the digits from 0 to 9 should ...
6 years, 7 months ago (2014-05-20 15:46:56 UTC) #4
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 7 months ago (2014-05-21 06:52:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/285293007/110001
6 years, 7 months ago (2014-05-21 06:52:26 UTC) #6
pals
On 2014/05/20 15:46:56, Julien Chaffraix - CET wrote: > lgtm > > https://codereview.chromium.org/285293007/diff/10001/LayoutTests/scrollbars/rtl/overflow-scroll-rtl.html > File ...
6 years, 7 months ago (2014-05-21 13:57:37 UTC) #7
Julien - ping for review
On 2014/05/21 13:57:37, sanjoy.pal wrote: > On 2014/05/20 15:46:56, Julien Chaffraix - CET wrote: > ...
6 years, 7 months ago (2014-05-23 10:32:38 UTC) #8
Dirk Pranke
The mac's mock scrollbars are rendered internally by webcore (they came from the apple port ...
6 years, 7 months ago (2014-05-23 16:20:34 UTC) #9
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 7 months ago (2014-05-26 07:31:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/285293007/170001
6 years, 7 months ago (2014-05-26 07:31:56 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 07:32:07 UTC) #12
commit-bot: I haz the power
Failed to apply patch for LayoutTests/platform/win/fast/block/float/026-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-26 07:32:07 UTC) #13
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 7 months ago (2014-05-26 12:01:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/285293007/230001
6 years, 7 months ago (2014-05-26 12:01:18 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 13:22:20 UTC) #16
Message was sent while issue was closed.
Change committed as 174808

Powered by Google App Engine
This is Rietveld 408576698