LayoutTests/scrollbars/rtl/overflow-scroll-rtl.html - Issue 285293007: Fix layoutOverflowRect in case of explicit 'overflow: scroll', but no overflow content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/scrollbars/rtl/overflow-scroll-rtl.html

Issue 285293007: Fix layoutOverflowRect in case of explicit 'overflow: scroll', but no overflow content (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/platform/win/fast/block/float/028-expected.txt ('k') | Source/core/rendering/RenderBlockLineLayout.cpp » ('j') | Source/core/rendering/RenderBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>All the digits from 0 to 9 should be visible.</p>
	Julien - ping for review 2014/05/20 15:46:56 The text is what makes the test platform-dependent The text is what makes the test platform-dependent. The WebKit wiki has a great article on how to write platform-independent tests (it's down right now and we should decide to write a similar page). Basically to avoid that you should put: html { font: 10px Ahem; -webkit-font-smoothing: none; } The output will be unreadable in DRT but that's expected and it avoids baseline explosion.
	3 <div id="outer" style="direction: rtl; background-color: blue; width: 200px; hei ght: 200px; overflow: scroll;">

	4 <div id="inner" style="background-color: lightgreen;">0123456789</div>

	5 </div>
	Julien - ping for review 2014/05/19 14:36:19 This test should use mock scrollbars to avoid bein This test should use mock scrollbars to avoid being highly platform dependent. A ref-test would be even better but I don't think is a good way to test this change. pals 2014/05/20 09:20:19 Done. Show quoted text On 2014/05/19 14:36:19, Julien Chaffraix - CET wrote: > This test should use mock scrollbars to avoid being highly platform dependent. A > ref-test would be even better but I don't think is a good way to test this > change. Done.
OLD	NEW