Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: gpu/command_buffer/service/shader_manager.h

Issue 2852923004: Remove NameMap from shader translator and shader/program managers (Closed)
Patch Set: remove some TODO(zmo)s Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/shader_manager.h
diff --git a/gpu/command_buffer/service/shader_manager.h b/gpu/command_buffer/service/shader_manager.h
index 29d50660a24235090a92d19b8e73d0ebccd03a95..c9c2df3a4694f24672397547d35ac6ea6909ef05 100644
--- a/gpu/command_buffer/service/shader_manager.h
+++ b/gpu/command_buffer/service/shader_manager.h
@@ -121,12 +121,10 @@ class GPU_EXPORT Shader : public base::RefCounted<Shader> {
const std::string& original_name) const;
// If the hashed_name is not found, return NULL.
+ // Use this only when one of the more specific Get*Info methods can't be used.
const std::string* GetOriginalNameFromHashedName(
const std::string& hashed_name) const;
- const std::string* GetMappedName(
- const std::string& original_name) const;
-
const std::string& log_info() const {
return log_info_;
}
@@ -259,9 +257,7 @@ class GPU_EXPORT Shader : public base::RefCounted<Shader> {
VaryingMap varying_map_;
InterfaceBlockMap interface_block_map_;
OutputVariableList output_variable_list_;
-
- // The name hashing info when the shader was last compiled.
- NameMap name_map_;
+ // If a new info type is added, add it to GetOriginalNameFromHashedName.
};
// Tracks the Shaders.
« no previous file with comments | « gpu/command_buffer/service/program_manager_unittest.cc ('k') | gpu/command_buffer/service/shader_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698