Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2852913002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from Editor::ChangeSelectionAfterCommand (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from Editor::ChangeSelectionAfterCommand This patch prunes a call site of the deprecated function to improve code health. The change is safe because the call site only needs the selection type, not the selection itself. After this patch, it also aligns with the code in Editor::RespondToChangedSelection. BUG=698633 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2852913002 Cr-Commit-Position: refs/heads/master@{#468304} Committed: https://chromium.googlesource.com/chromium/src/+/08b287f8807022c5c6369eafccad38ad3492cd9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Xiaocheng
PTAL.
3 years, 7 months ago (2017-05-01 06:10:45 UTC) #7
tkent
lgtm
3 years, 7 months ago (2017-05-01 07:10:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852913002/1
3 years, 7 months ago (2017-05-01 07:10:58 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 07:14:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08b287f8807022c5c6369eafccad...

Powered by Google App Engine
This is Rietveld 408576698