Settings reset prompt: Fix crash when fetching default settings.

Settings reset prompt: Fix crash when fetching default settings.

When the Chrome installation has a brand code, the SettingsResetPromptModel may try to fetch default settings over the network. If the fetch fails, the ProfileResetter is passed a null pointer and any attempt to reset a setting will crash.

BUG=716372
Review-Url: https://codereview.chromium.org/2852883002
Cr-Commit-Position: refs/heads/master@{#468270}
Committed: https://chromium.googlesource.com/chromium/src/+/2f2f39f646d36d9c56b723666a50fdeed43f90c2

[alito, 2017-05-01 00:36:23]

alito@chromium.org changed reviewers:
+ robertshield@google.com

[alito, 2017-05-01 00:36:23]

PTAL!

[alito, 2017-05-01 00:39:17]

Description was changed from

==========
Settings reset prompt: Fix crash when fetching default settings.

BUG=716372
==========

to

==========
Settings reset prompt: Fix crash when fetching default settings.

When the Chrome installation has a brand code, the SettingsResetPromptModel may
try to fetch default settings over the network. If the fetch fails, the
ProfileResetter is passed a null pointer and any attempt to reset a setting will
crash.

BUG=716372
==========

[robertshield, 2017-05-01 01:43:03]

robertshield@chromium.org changed reviewers:
+ robertshield@chromium.org

[robertshield, 2017-05-01 01:43:03]

lgtm, is this unit-testable?

[alito, 2017-05-01 01:50:00]

On 2017/05/01 01:43:03, robertshield wrote:
> lgtm, is this unit-testable?

Will need some refactoring (I need to be able to inject the settings fetcher for
testing to be able to mock what it returns). I'll land this simple fix for now
and send a follow-up CL with a test.

[alito, 2017-05-01 01:50:07]

The CQ bit was checked by alito@chromium.org

[commit-bot: I haz the power, 2017-05-01 01:50:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 02:49:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493603407189630, "parent_rev":
"303d2fcbe30651217015c0c7cfbfdb3fecf2a16a", "commit_rev":
"2f2f39f646d36d9c56b723666a50fdeed43f90c2"}

[commit-bot: I haz the power, 2017-05-01 02:49:31]

Description was changed from

==========
Settings reset prompt: Fix crash when fetching default settings.

When the Chrome installation has a brand code, the SettingsResetPromptModel may
try to fetch default settings over the network. If the fetch fails, the
ProfileResetter is passed a null pointer and any attempt to reset a setting will
crash.

BUG=716372
==========

to

==========
Settings reset prompt: Fix crash when fetching default settings.

When the Chrome installation has a brand code, the SettingsResetPromptModel may
try to fetch default settings over the network. If the fetch fails, the
ProfileResetter is passed a null pointer and any attempt to reset a setting will
crash.

BUG=716372

Review-Url: https://codereview.chromium.org/2852883002
Cr-Commit-Position: refs/heads/master@{#468270}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f2f39f646d36d9c56b723666a50...
==========

[commit-bot: I haz the power, 2017-05-01 02:49:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f2f39f646d36d9c56b723666a50...