Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2852813002: When receiving a key event on ChromeOS, set host lock state to match client's (Closed)

Created:
3 years, 7 months ago by rkjnsn
Modified:
3 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

When receiving a key event on ChromeOS, set host lock state to match client's BUG=176436 Review-Url: https://codereview.chromium.org/2852813002 Cr-Commit-Position: refs/heads/master@{#468762} Committed: https://chromium.googlesource.com/chromium/src/+/25188be9b29b34ae70d5f380c5eeefeeee3eb845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M remoting/host/input_injector_chromeos.cc View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
rkjnsn
I think this is all that is needed, here. This is, of course, untested.
3 years, 7 months ago (2017-04-29 00:43:55 UTC) #2
Jamie
LGTM, but please take an action item to test this once it lands on dev ...
3 years, 7 months ago (2017-04-29 00:53:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852813002/1
3 years, 7 months ago (2017-05-02 18:42:51 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 20:25:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25188be9b29b34ae70d5f380c5ee...

Powered by Google App Engine
This is Rietveld 408576698