Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: media/audio/audio_output_device_unittest.cc

Issue 2852803002: Remove base::SharedMemory::ShareToProcess. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_device_unittest.cc
diff --git a/media/audio/audio_output_device_unittest.cc b/media/audio/audio_output_device_unittest.cc
index e6ede19a2858597b055ed08bad64238931b68e67..70bba52a352a0e48b47fb79d87365ee894c9a88b 100644
--- a/media/audio/audio_output_device_unittest.cc
+++ b/media/audio/audio_output_device_unittest.cc
@@ -227,9 +227,9 @@ void AudioOutputDeviceTest::CreateStream() {
SyncSocket::TransitDescriptor audio_device_socket_descriptor;
ASSERT_TRUE(renderer_socket_.PrepareTransitDescriptor(
base::GetCurrentProcessHandle(), &audio_device_socket_descriptor));
- base::SharedMemoryHandle duplicated_memory_handle;
- ASSERT_TRUE(shared_memory_.ShareToProcess(base::GetCurrentProcessHandle(),
- &duplicated_memory_handle));
+ base::SharedMemoryHandle duplicated_memory_handle =
+ shared_memory_.handle().Duplicate();
+ ASSERT_TRUE(duplicated_memory_handle.IsValid());
audio_device_->OnStreamCreated(
duplicated_memory_handle,
Nico 2017/05/02 20:08:01 Didn't verify that this one assumes ownership.
erikchen 2017/05/02 21:33:10 I looked at real use cases of OnStreamCreated, and

Powered by Google App Engine
This is Rietveld 408576698