Remove base::SharedMemory::ShareToProcess.

media/audio/audio_output_device_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <vector>
 
 #include "base/at_exit.h"
 #include "base/bind_helpers.h"
@@ skipping 209 matching lines @@
 
   ASSERT_TRUE(CancelableSyncSocket::CreatePair(&browser_socket_,
                                                &renderer_socket_));
 
   // Create duplicates of the handles we pass to AudioOutputDevice since
   // ownership will be transferred and AudioOutputDevice is responsible for
   // freeing.
   SyncSocket::TransitDescriptor audio_device_socket_descriptor;
   ASSERT_TRUE(renderer_socket_.PrepareTransitDescriptor(
       base::GetCurrentProcessHandle(), &audio_device_socket_descriptor));
-  base::SharedMemoryHandle duplicated_memory_handle;
-  ASSERT_TRUE(shared_memory_.ShareToProcess(base::GetCurrentProcessHandle(),
-                                            &duplicated_memory_handle));
+  base::SharedMemoryHandle duplicated_memory_handle =
+      shared_memory_.handle().Duplicate();
+  ASSERT_TRUE(duplicated_memory_handle.IsValid());
 
   audio_device_->OnStreamCreated(
       duplicated_memory_handle,

[Nico, 2017/05/02 20:08:01]

Didn't verify that this one assumes ownership.

[erikchen, 2017/05/02 21:33:10]

I looked at real use cases of OnStreamCreated, and am pretty sure that there
exists code paths that cause the handle to leak. Added a TODO here.

       SyncSocket::UnwrapHandle(audio_device_socket_descriptor), kMemorySize);
   base::RunLoop().RunUntilIdle();
 }
 
 void AudioOutputDeviceTest::ExpectRenderCallback() {
   // We should get a 'play' notification when we call OnStreamCreated().
   // Respond by asking for some audio data.  This should ask our callback
   // to provide some audio data that AudioOutputDevice then writes into the
   // shared memory section.
   EXPECT_CALL(*audio_output_ipc_, PlayStream())
@@ skipping 132 matching lines @@
   // Runs the loop and waits for |thread| to call event's closure.
   event.RunAndWait();
 
   audio_device_->Stop();
   base::RunLoop().RunUntilIdle();
 }
 
 INSTANTIATE_TEST_CASE_P(Render, AudioOutputDeviceTest, Values(false));
 
 }  // namespace media.