Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2852753003: Gracefully handle tests finishing simultanously in 2+ secondary windows. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gracefully handle tests finishing simultanously in 2+ secondary renderers. This CL makes the layout tests harness more resiliant against a situation where testRunner.notifyDone() is called simultaneously in more than 1 renderer process. Such situation usually indicates a bug in the test (e.g. see https://crbug.com/716085#c13), but this shouldn't cause a crash or other problems in the layout tests harness. BUG=716085 Review-Url: https://codereview.chromium.org/2852753003 Cr-Commit-Position: refs/heads/master@{#468997} Committed: https://chromium.googlesource.com/chromium/src/+/2823efd6fec41c2ab4f47d3b241bc6e4330bb3fc

Patch Set 1 #

Patch Set 2 : s/secondary windows/secondary renderers/g #

Patch Set 3 : Adding regression tests for https://crbug.com/716085#c10. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/misc/tests-finishing-simultaneously.html View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/misc/tests-finishing-simultaneously-expected.txt View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Łukasz Anforowicz
mkwst@, can you PTAL?
3 years, 7 months ago (2017-04-29 00:08:09 UTC) #4
Mike West
Code change LGTM. Can you add a test for this behavior?
3 years, 7 months ago (2017-05-02 07:03:29 UTC) #12
Łukasz Anforowicz
On 2017/05/02 07:03:29, Mike West wrote: > Code change LGTM. Thanks. > Can you add ...
3 years, 7 months ago (2017-05-02 21:38:25 UTC) #13
Mike West
Thanks for the test! LGTM.
3 years, 7 months ago (2017-05-03 07:37:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852753003/40001
3 years, 7 months ago (2017-05-03 16:10:33 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 16:16:25 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2823efd6fec41c2ab4f47d3b241b...

Powered by Google App Engine
This is Rietveld 408576698