Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2852673003: webkitpy: Remove unnecessary code in test_copier.py (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Remove unnecessary code in test_copier.py 1. A local variable |copied_files| is never read. Remove it. 2. So, copy_file() needs to return nothing. 3. Then, _webkit_root is removable. Review-Url: https://codereview.chromium.org/2852673003 Cr-Commit-Position: refs/heads/master@{#468262} Committed: https://chromium.googlesource.com/chromium/src/+/1d2108cce478cac9751c40efc18e06d12a7a1f2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py View 4 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
jeffcarp@, would you review this please?
3 years, 7 months ago (2017-04-28 09:35:28 UTC) #4
jeffcarp
lgtm
3 years, 7 months ago (2017-04-28 22:20:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852673003/1
3 years, 7 months ago (2017-04-30 22:24:08 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-30 23:56:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d2108cce478cac9751c40efc18e...

Powered by Google App Engine
This is Rietveld 408576698