Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2852673002: Removed ChromeBrowserState::AsTestChromeBrowserState. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed ChromeBrowserState::AsTestChromeBrowserState. BUG=583682 Review-Url: https://codereview.chromium.org/2852673002 Cr-Commit-Position: refs/heads/master@{#467949} Committed: https://chromium.googlesource.com/chromium/src/+/fbeb99d9b4804941696a8396e7e84f1168c48f46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M ios/chrome/browser/browser_state/chrome_browser_state.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-04-28 08:05:36 UTC) #3
sdefresne
lgtm
3 years, 7 months ago (2017-04-28 10:17:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852673002/1
3 years, 7 months ago (2017-04-28 10:17:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fbeb99d9b4804941696a8396e7e84f1168c48f46
3 years, 7 months ago (2017-04-28 10:21:37 UTC) #12
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-04-28 11:30:28 UTC) #13
Message was sent while issue was closed.
Thanks for quick review!

Powered by Google App Engine
This is Rietveld 408576698