Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2852653004: Remove aura::Window::hit_test_bounds_override_inner_ (Closed)

Created:
3 years, 7 months ago by tdanderson
Modified:
3 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove aura::Window::hit_test_bounds_override_inner_ The |hit_test_bounds_override_inner_| member of aura::Window is no longer used, so remove it. No functional changes. BUG=344924 TEST=aura_unittests TBR=varkha@chromium.org Review-Url: https://codereview.chromium.org/2852653004 Cr-Commit-Position: refs/heads/master@{#468328} Committed: https://chromium.googlesource.com/chromium/src/+/d9be36beb116e054e19554bc4674526ac574a9a2

Patch Set 1 #

Patch Set 2 : iwyu #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -38 lines) Patch
M ash/wm/resize_shadow.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window.h View 3 chunks +0 lines, -14 lines 0 comments Download
M ui/aura/window.cc View 3 chunks +8 lines, -17 lines 0 comments Download
M ui/aura/window_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M ui/keyboard/content/keyboard_ui_content.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
tdanderson
Sadrul, can you please take a look?
3 years, 7 months ago (2017-04-28 18:38:19 UTC) #7
sadrul
cool! lgtm
3 years, 7 months ago (2017-05-01 15:37:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852653004/40001
3 years, 7 months ago (2017-05-01 16:01:19 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/424340)
3 years, 7 months ago (2017-05-01 16:10:18 UTC) #19
tdanderson
TBR'ing varkha@chromium.org for the #include in ash/wm
3 years, 7 months ago (2017-05-01 16:13:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852653004/40001
3 years, 7 months ago (2017-05-01 16:14:29 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 16:54:46 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d9be36beb116e054e19554bc4674...

Powered by Google App Engine
This is Rietveld 408576698