added a headlessresourcedispatcherhostdelegate so that we do not crash when a website requests a cl…

added a headlessresourcedispatcherhostdelegate so that we do not crash when a website requests a client cert store

BUG=714534
Review-Url: https://codereview.chromium.org/2852633002
Cr-Commit-Position: refs/heads/master@{#468280}
Committed: https://chromium.googlesource.com/chromium/src/+/e284fdd7988ff1d5545e64bf8eae062980231e2b

[Oleg Sushkov, 2017-04-28 05:36:52]

sushkov@chromium.org changed reviewers:
+ skyostil@chromium.org

[Oleg Sushkov, 2017-04-28 05:36:52]

Fix for Segfault crash in create client cert store due to not having a delegate
in headless.

[Sami, 2017-04-28 09:42:44]

lgtm, although a small smoke test would be nice :)

[Oleg Sushkov, 2017-05-01 01:36:53]

The CQ bit was checked by sushkov@chromium.org

[commit-bot: I haz the power, 2017-05-01 01:37:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 03:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 03:30:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Oleg Sushkov, 2017-05-01 03:50:58]

The CQ bit was checked by sushkov@chromium.org

[commit-bot: I haz the power, 2017-05-01 03:51:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 04:20:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493610658258860, "parent_rev":
"a7bdae0c8fc2af8615d676c546cef735a131a8f1", "commit_rev":
"e284fdd7988ff1d5545e64bf8eae062980231e2b"}

[commit-bot: I haz the power, 2017-05-01 04:20:30]

Description was changed from

==========
added a headlessresourcedispatcherhostdelegate so that we do not crash when a
website requests a client cert store

BUG=714534
==========

to

==========
added a headlessresourcedispatcherhostdelegate so that we do not crash when a
website requests a client cert store

BUG=714534

Review-Url: https://codereview.chromium.org/2852633002
Cr-Commit-Position: refs/heads/master@{#468280}
Committed:
https://chromium.googlesource.com/chromium/src/+/e284fdd7988ff1d5545e64bf8eae...
==========

[commit-bot: I haz the power, 2017-05-01 04:20:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e284fdd7988ff1d5545e64bf8eae...

[Oleg Sushkov, 2017-05-01 04:59:50]

On 2017/04/28 at 09:42:44, skyostil wrote:
> lgtm, although a small smoke test would be nice :)

How would you suggest doing a smoke test? Just checking that the class doesnt
return a nullptr in headless seems a bit reductive. Whereas checking that
headless doesnt crash on that particular URL seems reliant on the website not
changing going forward.

[Sami, 2017-05-03 10:49:12]

On 2017/05/01 04:59:50, Oleg Sushkov wrote:
> How would you suggest doing a smoke test? Just checking that the class doesnt
> return a nullptr in headless seems a bit reductive. Whereas checking that
> headless doesnt crash on that particular URL seems reliant on the website not
> changing going forward.

We could create our own test-only website that requests a client cert store. I
don't know which API exactly is used for that and a quick search wasn't
successful, but I guess there is a way if we were hitting this crash :)