Media Capabilities: stricter checks for the media configuration inputs.

Media Capabilities: stricter checks for the media configuration inputs.

This is checking the framerate value, the content type, etc.

Spec change:
https://github.com/WICG/media-capabilities/commit/741d312207bac0bf5a61dba539c0ee7890d98138

BUG=690380
Review-Url: https://codereview.chromium.org/2852563002
Cr-Commit-Position: refs/heads/master@{#470946}
Committed: https://chromium.googlesource.com/chromium/src/+/b99daebfd25fdf8346fcef1110afd26bd971308a

[mlamouri (slow - plz ping), 2017-04-27 22:18:27]

mlamouri@chromium.org changed reviewers:
+ chcunningham@chromium.org

[mlamouri (slow - plz ping), 2017-04-27 22:18:27]

PTAL. It's early but thought I would upload this in case of you can have a look.

[chcunningham, 2017-05-01 18:54:03]

Looks good. Enjoy the time off ;)

[mlamouri (slow - plz ping), 2017-05-09 12:31:37]

Description was changed from

==========
Media Capabilities: stricter checks for the media configuration inputs.

This is checking the framerate value, the content type, etc.
TODO: link to spec change.

BUG=<TODO>
==========

to

==========
Media Capabilities: stricter checks for the media configuration inputs.

This is checking the framerate value, the content type, etc.

Spec change:
https://github.com/WICG/media-capabilities/commit/741d312207bac0bf5a61dba539c...

BUG=690380
==========

[mlamouri (slow - plz ping), 2017-05-09 13:01:26]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[mlamouri (slow - plz ping), 2017-05-09 13:01:57]

chcunningham@, PTAL :)

[commit-bot: I haz the power, 2017-05-09 13:01:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 14:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 14:42:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chcunningham, 2017-05-10 21:10:14]

LGTM % HLS mime

https://codereview.chromium.org/2852563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
(right):

https://codereview.chromium.org/2852563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp:28:
constexpr const char* kVideoMimeTypePrefix = "video/";
we may need to add in the HLS prefix "application/". See examples in mime code
here:

https://cs.chromium.org/chromium/src/media/base/mime_util_internal.cc?rcl=5fa...

IIUC, its not clear from the "application/" mime whether it will describe audio
or video, so it may just be an allowed option in both configs.

[mlamouri (slow - plz ping), 2017-05-11 10:40:25]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-05-11 10:40:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
chcunningham@chromium.org
Link to the patchset: https://codereview.chromium.org/2852563002/#ps40001
(title: "review comments and encoding tests")

[commit-bot: I haz the power, 2017-05-11 10:41:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-05-11 10:41:23]

+mcasas@ in CC as I'm modifying encoding tests.

https://codereview.chromium.org/2852563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
(right):

https://codereview.chromium.org/2852563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp:28:
constexpr const char* kVideoMimeTypePrefix = "video/";
On 2017/05/10 at 21:10:13, chcunningham_OOO_May9 wrote:
> we may need to add in the HLS prefix "application/". See examples in mime code
here:
> 
>
https://cs.chromium.org/chromium/src/media/base/mime_util_internal.cc?rcl=5fa...
> 
> IIUC, its not clear from the "application/" mime whether it will describe
audio or video, so it may just be an allowed option in both configs.

That means we should update the specification, right? Will file a spec bug and
update the CL.

[commit-bot: I haz the power, 2017-05-11 13:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 13:05:24]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mlamouri (slow - plz ping), 2017-05-11 13:41:51]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2017-05-11 13:42:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 14:25:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494510111079800,
"parent_rev": "31a9f6426ec06155f4b95e5e125d76e0371d0c74", "commit_rev":
"b99daebfd25fdf8346fcef1110afd26bd971308a"}

[commit-bot: I haz the power, 2017-05-11 14:25:38]

Description was changed from

==========
Media Capabilities: stricter checks for the media configuration inputs.

This is checking the framerate value, the content type, etc.

Spec change:
https://github.com/WICG/media-capabilities/commit/741d312207bac0bf5a61dba539c...

BUG=690380
==========

to

==========
Media Capabilities: stricter checks for the media configuration inputs.

This is checking the framerate value, the content type, etc.

Spec change:
https://github.com/WICG/media-capabilities/commit/741d312207bac0bf5a61dba539c...

BUG=690380

Review-Url: https://codereview.chromium.org/2852563002
Cr-Commit-Position: refs/heads/master@{#470946}
Committed:
https://chromium.googlesource.com/chromium/src/+/b99daebfd25fdf8346fcef1110af...
==========

[commit-bot: I haz the power, 2017-05-11 14:25:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b99daebfd25fdf8346fcef1110af...