Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2852553003: cros: Fix video unittests on cros device. (Closed)

Created:
3 years, 7 months ago by sadrul
Modified:
3 years, 7 months ago
Reviewers:
kcwu, wuchengli
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org, kcwu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix video unittests on cros device. Some ozone platforms (e.g. drm) expects to be able to watch a file descriptor, so use a TYPE_IO message-loop for the gpu process host thread. BUG=715957 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2852553003 Cr-Commit-Position: refs/heads/master@{#467889} Committed: https://chromium.googlesource.com/chromium/src/+/ea02813b6067f1ff6b52cb59f03abeed96676214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M media/gpu/video_decode_accelerator_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sadrul
wuchengli@ Please review. Thanks! kcwu@ FYI
3 years, 7 months ago (2017-04-28 02:10:17 UTC) #4
kcwu
lgtm
3 years, 7 months ago (2017-04-28 03:23:54 UTC) #7
wuchengli
lgtm
3 years, 7 months ago (2017-04-28 04:22:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852553003/1
3 years, 7 months ago (2017-04-28 04:30:15 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:15:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea02813b6067f1ff6b52cb59f03a...

Powered by Google App Engine
This is Rietveld 408576698