Remove the use of custom logic to determine search suggestion types.

Remove the use of custom logic to determine search suggestion types.

iOS has a custom method for determining which omnibox suggestion types
are search/query types (as opposed to URL types). This change removes it
in favor of the cross-platform method used on other platforms. This has
useful effects on how we display navsuggest and calculator suggestions
and eliminates the need to maintain separate logic.

See the bug for a detailed description of the motivation for this change
and an analysis of its effects.

BUG=716047
Review-Url: https://codereview.chromium.org/2852553002
Cr-Commit-Position: refs/heads/master@{#468317}
Committed: https://chromium.googlesource.com/chromium/src/+/97567bc01417a53c3157e0fe0fb3e8c4ce714db1

[Justin Donnelly, 2017-04-27 21:45:41]

The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:46:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Donnelly, 2017-04-27 21:47:31]

jdonnelly@chromium.org changed reviewers:
+ rohitrao@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:41:16]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-05-01 15:32:09]

LGTM

I don't remember the history of why we have a separate method on iOS.  Thanks
for annotating the bug with a list of what specific types would be handled
differently -- from that list, all of the changes seem beneficial and nothing
looks concerning.

[Justin Donnelly, 2017-05-01 15:40:40]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2017-05-01 15:41:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 15:50:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493653240779150, "parent_rev":
"3016c7260fec3bd2485a0377166bb0aa52112a15", "commit_rev":
"97567bc01417a53c3157e0fe0fb3e8c4ce714db1"}

[commit-bot: I haz the power, 2017-05-01 15:51:08]

Description was changed from

==========
Remove the use of custom logic to determine search suggestion types.

iOS has a custom method for determining which omnibox suggestion types
are search/query types (as opposed to URL types). This change removes it
in favor of the cross-platform method used on other platforms. This has
useful effects on how we display navsuggest and calculator suggestions
and eliminates the need to maintain separate logic.

See the bug for a detailed description of the motivation for this change
and an analysis of its effects.

BUG=716047
==========

to

==========
Remove the use of custom logic to determine search suggestion types.

iOS has a custom method for determining which omnibox suggestion types
are search/query types (as opposed to URL types). This change removes it
in favor of the cross-platform method used on other platforms. This has
useful effects on how we display navsuggest and calculator suggestions
and eliminates the need to maintain separate logic.

See the bug for a detailed description of the motivation for this change
and an analysis of its effects.

BUG=716047

Review-Url: https://codereview.chromium.org/2852553002
Cr-Commit-Position: refs/heads/master@{#468317}
Committed:
https://chromium.googlesource.com/chromium/src/+/97567bc01417a53c3157e0fe0fb3...
==========

[commit-bot: I haz the power, 2017-05-01 15:51:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97567bc01417a53c3157e0fe0fb3...