Add lite page BTF test

Add lite page BTF test

BUG=715644
Review-Url: https://codereview.chromium.org/2852533002
Cr-Commit-Position: refs/heads/master@{#467775}
Committed: https://chromium.googlesource.com/chromium/src/+/d9b2071593f2049982dde69ade697170e85cdb96

[Robert Ogden, 2017-04-27 19:50:29]

Description was changed from

==========
Add lite page BTF test

BUG=715644
==========

to

==========
Add lite page BTF test

BUG=715644
==========

[Robert Ogden, 2017-04-27 19:50:30]

robertogden@chromium.org changed reviewers:
+ ryansturm@chromium.org

[Robert Ogden, 2017-04-27 19:50:39]

Ryan, please take a look

[RyanSturm, 2017-04-27 20:11:13]

lgtm % nit

https://codereview.chromium.org/2852533002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2852533002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:430: override_has_logs: Allow the
_has_logs property to be set if there was not
s/Allow/Allows/

[Robert Ogden, 2017-04-27 20:17:08]

https://codereview.chromium.org/2852533002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2852533002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:430: override_has_logs: Allow the
_has_logs property to be set if there was not
On 2017/04/27 20:11:13, Ryan Sturm wrote:
> s/Allow/Allows/

Done.

[Robert Ogden, 2017-04-27 20:17:11]

The CQ bit was checked by robertogden@chromium.org

[Robert Ogden, 2017-04-27 20:17:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2852533002/#ps20001
(title: "Grammer nit")

[commit-bot: I haz the power, 2017-04-27 20:17:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:40:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493324231138030,
"parent_rev": "e9fd73b521485674c0039982eecf6adf52520d9e", "commit_rev":
"d9b2071593f2049982dde69ade697170e85cdb96"}

[commit-bot: I haz the power, 2017-04-27 20:40:36]

Description was changed from

==========
Add lite page BTF test

BUG=715644
==========

to

==========
Add lite page BTF test

BUG=715644

Review-Url: https://codereview.chromium.org/2852533002
Cr-Commit-Position: refs/heads/master@{#467775}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9b2071593f2049982dde69ade69...
==========

[commit-bot: I haz the power, 2017-04-27 20:40:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9b2071593f2049982dde69ade69...

[tombergan, 2017-04-27 22:19:58]

https://codereview.chromium.org/2852533002/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/lite_page.py (right):

https://codereview.chromium.org/2852533002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/lite_page.py:84:
self.assertHasChromeProxyViaHeader(response)
IIUC, this checks that there was another response but doesn't check that it was
successful, i.e., that new BTF content was actually loaded?

Maybe instead of scrolling twice, check that the scrollHeight increased after
the first scroll all the way to the bottom?

[Robert Ogden, 2017-04-28 15:25:27]

On 2017/04/27 22:19:58, tombergan wrote:
>
https://codereview.chromium.org/2852533002/diff/20001/tools/chrome_proxy/webd...
> File tools/chrome_proxy/webdriver/lite_page.py (right):
> 
>
https://codereview.chromium.org/2852533002/diff/20001/tools/chrome_proxy/webd...
> tools/chrome_proxy/webdriver/lite_page.py:84:
> self.assertHasChromeProxyViaHeader(response)
> IIUC, this checks that there was another response but doesn't check that it
was
> successful, i.e., that new BTF content was actually loaded?
> 
> Maybe instead of scrolling twice, check that the scrollHeight increased after
> the first scroll all the way to the bottom?

Done, although since this CL already landed I've gone it in
https://codereview.chromium.org/2844403002/. Please take a look.