Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 285253002: kiosk: Remove all cached CRX when removing a kiosk app. (Closed)

Created:
6 years, 7 months ago by jennyz
Modified:
6 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

kiosk: Remove all cached CRX when removing a kiosk app BUG=373473 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270885

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix a typo and remove CHECK for deleting files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -8 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc View 3 chunks +47 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 1 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jennyz
6 years, 7 months ago (2014-05-15 00:10:01 UTC) #1
Dmitry Polukhin
lgtm
6 years, 7 months ago (2014-05-15 00:49:23 UTC) #2
xiyuan
LGTM Suggest to rephrase CL description a bit to make it easier to see it's ...
6 years, 7 months ago (2014-05-15 01:04:46 UTC) #3
jennyz
6 years, 7 months ago (2014-05-15 16:25:54 UTC) #4
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 7 months ago (2014-05-15 16:26:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/285253002/1
6 years, 7 months ago (2014-05-15 16:27:40 UTC) #6
jennyz
asargent@, can you take a look at the change I made in local_extension_cache.cc? Both xiyuan ...
6 years, 7 months ago (2014-05-15 17:37:48 UTC) #7
asargent_no_longer_on_chrome
https://codereview.chromium.org/285253002/diff/1/chrome/browser/extensions/updater/local_extension_cache.cc File chrome/browser/extensions/updater/local_extension_cache.cc (right): https://codereview.chromium.org/285253002/diff/1/chrome/browser/extensions/updater/local_extension_cache.cc#newcode443 chrome/browser/extensions/updater/local_extension_cache.cc:443: std::string file_patthen = id + "-*" + kCRXFileExtension; nit: ...
6 years, 7 months ago (2014-05-15 17:49:01 UTC) #8
jennyz
https://codereview.chromium.org/285253002/diff/1/chrome/browser/extensions/updater/local_extension_cache.cc File chrome/browser/extensions/updater/local_extension_cache.cc (right): https://codereview.chromium.org/285253002/diff/1/chrome/browser/extensions/updater/local_extension_cache.cc#newcode443 chrome/browser/extensions/updater/local_extension_cache.cc:443: std::string file_patthen = id + "-*" + kCRXFileExtension; On ...
6 years, 7 months ago (2014-05-15 18:51:22 UTC) #9
asargent_no_longer_on_chrome
lgtm
6 years, 7 months ago (2014-05-15 21:51:25 UTC) #10
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 7 months ago (2014-05-15 22:04:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/285253002/40001
6 years, 7 months ago (2014-05-15 22:05:10 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 01:05:55 UTC) #13
Message was sent while issue was closed. 
Change committed as 270885

Powered by Google App Engine
This is Rietveld 408576698