kiosk: Remove all cached CRX when removing a kiosk app.

chrome/browser/extensions/updater/local_extension_cache.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/updater/local_extension_cache.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_enumerator.h"
 #include "base/sequenced_task_runner.h"
@@ skipping 127 matching lines @@
 bool LocalExtensionCache::RemoveExtension(const std::string& id) {
   if (state_ != kReady)
     return false;
 
   CacheMap::iterator it = cached_extensions_.find(id);
   if (it == cached_extensions_.end())
     return false;
 
   backend_task_runner_->PostTask(
       FROM_HERE,
-      base::Bind(&LocalExtensionCache::BackendRemoveCacheEntry,
-                 it->second.file_path));
+      base::Bind(
+          &LocalExtensionCache::BackendRemoveCacheEntry, cache_dir_, id));
 
   cached_extensions_.erase(it);
   return true;
 }
 
 bool LocalExtensionCache::GetStatistics(uint64* cache_size,
                                         size_t* extensions_count) {
   if (state_ != kReady)
     return false;
 
@@ skipping 271 matching lines @@
     it = cached_extensions_.insert(std::make_pair(id, info)).first;
   }
   // Time from file system can have lower precision so use precise "now".
   it->second.last_used = base::Time::Now();
 
   callback.Run(info.file_path, false);
 }
 
 // static
 void LocalExtensionCache::BackendRemoveCacheEntry(
-    const base::FilePath& file_path) {
-  base::DeleteFile(file_path, true /* recursive */);
-  VLOG(1) << "Removed cached file " << file_path.value();
+    const base::FilePath& cache_dir,
+    const std::string& id) {
+  std::string file_patthen = id + "-*" + kCRXFileExtension;

[asargent_no_longer_on_chrome, 2014/05/15 17:49:01]

nit: should this be "file_pattern" ?

[jennyz, 2014/05/15 18:51:22]

Done.

+  base::FileEnumerator enumerator(cache_dir,
+                                  false /* not recursive */,
+                                  base::FileEnumerator::FILES,
+                                  file_patthen);
+  for (base::FilePath path = enumerator.Next(); !path.empty();
+       path = enumerator.Next()) {
+    CHECK(base::DeleteFile(path, false));

[asargent_no_longer_on_chrome, 2014/05/15 17:49:01]

Is it appropriate to crash the whole browser if you can't delete this file? 

[jennyz, 2014/05/15 18:51:22]

Done.

+    VLOG(1) << "Removed cached file " << path.value();
+  }
 }
 
 // static
 bool LocalExtensionCache::CompareCacheItemsAge(const CacheMap::iterator& lhs,
                                                const CacheMap::iterator& rhs) {
   return lhs->second.last_used < rhs->second.last_used;
 }
 
 void LocalExtensionCache::CleanUp() {
   DCHECK_EQ(state_, kReady);
@@ skipping 21 matching lines @@
 
 LocalExtensionCache::CacheItemInfo::CacheItemInfo(
     const std::string& version,
     const base::Time& last_used,
     uint64 size,
     const base::FilePath& file_path)
     : version(version), last_used(last_used), size(size), file_path(file_path) {
 }
 
 }  // namespace extensions