Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2852493002: chromeos: Converts more tests to AshTestBase (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Converts more tests to AshTestBase BUG=707057 TEST=test only changes R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2852493002 Cr-Commit-Position: refs/heads/master@{#467811} Committed: https://chromium.googlesource.com/chromium/src/+/e87cbf96488f5a86d728fe23b573c25d1ea07fe2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -61 lines) Patch
M ash/system/brightness/tray_brightness_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/date/date_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/screen_security/screen_tray_item_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/mru_window_tracker_unittest.cc View 2 chunks +43 lines, -50 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 7 months ago (2017-04-27 15:55:55 UTC) #1
James Cook
lgtm
3 years, 7 months ago (2017-04-27 18:56:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852493002/1
3 years, 7 months ago (2017-04-27 21:51:00 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 01:46:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e87cbf96488f5a86d728fe23b573...

Powered by Google App Engine
This is Rietveld 408576698