Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2852483002: Remove GeolocationSettingsStateTests. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-geolocation_chromium.org, mcasas+geolocation_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GeolocationSettingsStateTests. It has been missing from .gn files for a while. The test looks very similar to chrome/browser/content_settings/content_settings_usages_state_unittest.cc and it looks like we just forgot to delete it in https://chromiumcodereview.appspot.com/19375002 BUG=661774 Review-Url: https://codereview.chromium.org/2852483002 Cr-Commit-Position: refs/heads/master@{#468125} Committed: https://chromium.googlesource.com/chromium/src/+/3531cd6ab4ee74146c2a0fd834a54c71c9c4178f

Patch Set 1 #

Patch Set 2 : actually #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -203 lines) Patch
M chrome/browser/geolocation/geolocation_settings_state_unittest.cc View 1 1 chunk +0 lines, -203 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Nico
3 years, 7 months ago (2017-04-27 15:23:49 UTC) #4
Elly Fong-Jones
lgtm
3 years, 7 months ago (2017-04-28 20:26:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852483002/20001
3 years, 7 months ago (2017-04-28 20:33:37 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 21:10:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3531cd6ab4ee74146c2a0fd834a5...

Powered by Google App Engine
This is Rietveld 408576698