Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2852443002: gn docs: Add a missing closing paren. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gn docs: Add a missing closing paren. BUG=none Review-Url: https://codereview.chromium.org/2852443002 Cr-Commit-Position: refs/heads/master@{#467724} Committed: https://chromium.googlesource.com/chromium/src/+/dd1ae15f741af316df1aefc7df74aa4427839250

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/gn/docs/reference.md View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/variables.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Nico
3 years, 7 months ago (2017-04-27 14:12:49 UTC) #4
brettw
lgtm
3 years, 7 months ago (2017-04-27 16:58:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852443002/20001
3 years, 7 months ago (2017-04-27 16:58:50 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 17:47:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd1ae15f741af316df1aefc7df74...

Powered by Google App Engine
This is Rietveld 408576698