Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2852433004: Add an experimental flag to change location.reload to take a hard-reload (Closed)

Created:
3 years, 7 months ago by Takashi Toyoshima
Modified:
3 years, 7 months ago
Reviewers:
kinuko, Ilya Sherman
CC:
chromium-reviews, jam, blink-reviews-api_chromium.org, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an experimental flag to change location.reload to take a hard-reload BUG=716339 Review-Url: https://codereview.chromium.org/2852433004 Cr-Commit-Position: refs/heads/master@{#469663} Committed: https://chromium.googlesource.com/chromium/src/+/9ff98be419da56e5586093be8113b28e3a018484

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : rebase #

Patch Set 4 : Merge branch 'master' into 2852433004 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -7 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Location.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
Takashi Toyoshima
ptal
3 years, 7 months ago (2017-04-28 07:52:20 UTC) #3
kinuko
(Chatted offline about the background & context as well) lgtm
3 years, 7 months ago (2017-04-28 08:21:53 UTC) #6
Takashi Toyoshima
+Ilya for histograms.xml
3 years, 7 months ago (2017-04-28 08:23:11 UTC) #8
Ilya Sherman
histograms.xml lgtm
3 years, 7 months ago (2017-04-28 21:10:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852433004/20001
3 years, 7 months ago (2017-05-05 08:53:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/67615)
3 years, 7 months ago (2017-05-05 08:56:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852433004/40001
3 years, 7 months ago (2017-05-05 12:02:20 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/204663)
3 years, 7 months ago (2017-05-05 12:05:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852433004/60001
3 years, 7 months ago (2017-05-05 13:54:01 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 15:53:46 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9ff98be419da56e5586093be8113...

Powered by Google App Engine
This is Rietveld 408576698