Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2852423002: Expose passwords to JavaScript in Credential Manager API (Closed)
Patch Set: More Interface Listings Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
index a91f136456639b4eb476551133781fa6d3958670..6af551ad01dc967a65a73dc7dc925dcadd93f9db 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
@@ -12,8 +12,10 @@
#include "core/dom/Document.h"
#include "core/dom/ExecutionContext.h"
#include "core/fileapi/Blob.h"
+#include "core/frame/Deprecation.h"
#include "core/frame/Frame.h"
#include "core/frame/SubresourceIntegrity.h"
+#include "core/frame/UseCounter.h"
#include "core/frame/csp/ContentSecurityPolicy.h"
#include "core/inspector/ConsoleMessage.h"
#include "core/loader/ThreadableLoader.h"
@@ -725,8 +727,11 @@ void FetchManager::Loader::PerformHTTPFetch(bool cors_flag,
request_->Method() != HTTPNames::HEAD) {
if (request_->Buffer())
request.SetHTTPBody(request_->Buffer()->DrainAsFormData());
- if (request_->AttachedCredential())
+ if (request_->AttachedCredential()) {
+ Deprecation::CountDeprecation(GetExecutionContext(),
+ UseCounter::kCredentialManagerCustomFetch);
Mike West 2017/05/04 11:13:33 I think it would be better to put this counter in
jdoerrie 2017/05/04 14:24:10 Done.
request.SetAttachedCredential(request_->AttachedCredential());
+ }
}
request.SetFetchRedirectMode(request_->Redirect());
request.SetUseStreamOnResponse(true);

Powered by Google App Engine
This is Rietveld 408576698