Expose passwords to JavaScript in Credential Manager API

third_party/WebKit/Source/modules/fetch/FetchManager.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/fetch/FetchManager.h"
 
 #include <memory>
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/V8ThrowException.h"
 #include "core/dom/DOMArrayBuffer.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/fileapi/Blob.h"
+#include "core/frame/Deprecation.h"
 #include "core/frame/Frame.h"
 #include "core/frame/SubresourceIntegrity.h"
+#include "core/frame/UseCounter.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "core/loader/ThreadableLoader.h"
 #include "core/loader/ThreadableLoaderClient.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/Page.h"
 #include "core/probe/CoreProbes.h"
 #include "modules/fetch/Body.h"
 #include "modules/fetch/BodyStreamBuffer.h"
 #include "modules/fetch/BytesConsumer.h"
@@ skipping 691 matching lines @@
   request.SetFetchCredentialsMode(request_->Credentials());
   for (const auto& header : request_->HeaderList()->List()) {
     request.AddHTTPHeaderField(AtomicString(header.first),
                                AtomicString(header.second));
   }
 
   if (request_->Method() != HTTPNames::GET &&
       request_->Method() != HTTPNames::HEAD) {
     if (request_->Buffer())
       request.SetHTTPBody(request_->Buffer()->DrainAsFormData());
-    if (request_->AttachedCredential())
+    if (request_->AttachedCredential()) {
+      Deprecation::CountDeprecation(GetExecutionContext(),
+                                    UseCounter::kCredentialManagerCustomFetch);

[Mike West, 2017/05/04 11:13:33]

I think it would be better to put this counter in the `RequestInit` constructor
instead. That would cover cases in which a developer constructed a `Request`
object separately from the call to `fetch()`. Since that will end up throwing in
the future, it's important to notify folks at the point we'd end up throwing.

[jdoerrie, 2017/05/04 14:24:10]

Done.

       request.SetAttachedCredential(request_->AttachedCredential());
+    }
   }
   request.SetFetchRedirectMode(request_->Redirect());
   request.SetUseStreamOnResponse(true);
   request.SetExternalRequestStateFromRequestorAddressSpace(
       execution_context_->GetSecurityContext().AddressSpace());
 
   // "2. Append `Referer`/empty byte sequence, if |HTTPRequest|'s |referrer|
   // is none, and `Referer`/|HTTPRequest|'s referrer, serialized and utf-8
   // encoded, otherwise, to HTTPRequest's header list.
   //
@@ skipping 181 matching lines @@
   loaders_.erase(loader);
   loader->Dispose();
 }
 
 DEFINE_TRACE(FetchManager) {
   visitor->Trace(loaders_);
   ContextLifecycleObserver::Trace(visitor);
 }
 
 }  // namespace blink