Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

Issue 2852423002: Expose passwords to JavaScript in Credential Manager API (Closed)
Patch Set: More Interface Listings Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
index fabea90145c8d1e37a0047c9e932899f755e4a8c..57e10dbf35072bb9ad368eae21b9fcd755ce0e01 100644
--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
@@ -45,9 +45,11 @@ class MODULES_EXPORT PasswordCredential final : public CredentialUserData {
out = additional_data_;
}
+ void setPassword(const String&);
Mike West 2017/05/04 11:13:33 I don't think we need this; it's a readonly attrib
jdoerrie 2017/05/04 14:24:10 I'm not quite sure, in the PR it's not: https://gi
Mike West 2017/05/05 11:35:10 I think the patch is incorrect, and added a commen
+ const String& password() const;
+
// Internal methods
PassRefPtr<EncodedFormData> EncodeFormData(String& content_type) const;
- const String& Password() const;
DECLARE_VIRTUAL_TRACE();
private:
@@ -59,6 +61,7 @@ class MODULES_EXPORT PasswordCredential final : public CredentialUserData {
String id_name_;
String password_name_;
+ String password_;
CredentialPostBodyType additional_data_;
};

Powered by Google App Engine
This is Rietveld 408576698