Expose passwords to JavaScript in Credential Manager API

third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PasswordCredential_h
 #define PasswordCredential_h
 
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/modules/v8/FormDataOrURLSearchParams.h"
 #include "modules/ModulesExport.h"
@@ skipping 27 matching lines @@
   void setPasswordName(const String& name) { password_name_ = name; }
   const String& passwordName() const { return password_name_; }
 
   void setAdditionalData(const CredentialPostBodyType& data) {
     additional_data_ = data;
   }
   void additionalData(CredentialPostBodyType& out) const {
     out = additional_data_;
   }
 
+  void setPassword(const String&);

[Mike West, 2017/05/04 11:13:33]

I don't think we need this; it's a readonly attribute, isn't it? 

[jdoerrie, 2017/05/04 14:24:10]

I'm not quite sure, in the PR it's not:
https://github.com/w3c/webappsec-credential-management/pull/76/files#diff-117...
I implemented your comment regarding DOMString, but I didn't know that it's
supposed to be readonly. I suppose that makes sense, though.

[Mike West, 2017/05/05 11:35:10]

I think the patch is incorrect, and added a comment to that effect. :)

+  const String& password() const;
+
   // Internal methods
   PassRefPtr<EncodedFormData> EncodeFormData(String& content_type) const;
-  const String& Password() const;
   DECLARE_VIRTUAL_TRACE();
 
  private:
   PasswordCredential(WebPasswordCredential*);
   PasswordCredential(const String& id,
                      const String& password,
                      const String& name,
                      const KURL& icon);
 
   String id_name_;
   String password_name_;
+  String password_;
   CredentialPostBodyType additional_data_;
 };
 
 }  // namespace blink
 
 #endif  // PasswordCredential_h