Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

Issue 2852423002: Expose passwords to JavaScript in Credential Manager API (Closed)
Patch Set: Console Message Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
index 8336951f821d8898d2c15b9d34eafd6b6fb5e23d..15030be66bd638c091e5cbe0252d0f9268e2de51 100644
--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
@@ -132,6 +132,11 @@ PasswordCredential::PasswordCredential(const String& id,
id_name_("username"),
password_name_("password") {}
+const String& PasswordCredential::password() const {
+ return static_cast<PlatformPasswordCredential*>(platform_credential_.Get())
+ ->Password();
+}
+
PassRefPtr<EncodedFormData> PasswordCredential::EncodeFormData(
String& content_type) const {
if (additional_data_.isURLSearchParams()) {
@@ -145,7 +150,7 @@ PassRefPtr<EncodedFormData> PasswordCredential::EncodeFormData(
params->append(name, param.second);
}
params->append(idName(), id());
- params->append(passwordName(), Password());
+ params->append(passwordName(), password());
content_type =
AtomicString("application/x-www-form-urlencoded;charset=UTF-8");
@@ -169,7 +174,7 @@ PassRefPtr<EncodedFormData> PasswordCredential::EncodeFormData(
}
}
form_data->append(idName(), id());
- form_data->append(passwordName(), Password());
+ form_data->append(passwordName(), password());
RefPtr<EncodedFormData> encoded_data = form_data->EncodeMultiPartFormData();
content_type = AtomicString("multipart/form-data; boundary=") +
@@ -177,11 +182,6 @@ PassRefPtr<EncodedFormData> PasswordCredential::EncodeFormData(
return encoded_data.Release();
}
-const String& PasswordCredential::Password() const {
- return static_cast<PlatformPasswordCredential*>(platform_credential_.Get())
- ->Password();
-}
-
DEFINE_TRACE(PasswordCredential) {
CredentialUserData::Trace(visitor);
visitor->Trace(additional_data_);

Powered by Google App Engine
This is Rietveld 408576698