chrome/browser/resources/settings/search_engines_page/search_engines_page.html - Issue 2852413003: MD Settings: omnibox extensions list to use focus-row-behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2852413003: MD Settings: omnibox extensions list to use focus-row-behavior. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('K') | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | chrome/browser/resources/settings/search_engines_page/search_engines_page.js » ('j') | chrome/browser/resources/settings/search_engines_page/search_engines_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

index 4cf645c01cf1e35931a1895ee586abdfff0a6407..5bb2f1ab01ad8ac7fc7972614c486460c303c218 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

@@ -49,10 +49,11 @@

<h2>$i18n{searchEnginesExtension}</h2>

</div>

<iron-list id="extensions" class="extension-engines fixed-height-list"

- selectable items="[[extensions]]">

+ items="[[extensions]]">

<settings-omnibox-extension-entry engine="[[item]]"

- tabindex$="[[tabIndex]]">

+ tabindex$="[[tabIndex]]" iron-list-tab-index="[[tabIndex]]"

hcarmona 2017/05/04 21:03:35 do you need both tabindex and iron-list-tab-index?

scottchen 2017/05/04 21:57:38 yeah, the js code uses them to do slightly differe

hcarmona 2017/05/04 22:51:35 SG

+ last-focused="{{OmniboxExtensionlastFocused_}}">

</settings-omnibox-extension-entry>

</template>

</iron-list>