Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2852413003: MD Settings: omnibox extensions list to use focus-row-behavior. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/html/action_link.html"> 2 <link rel="import" href="chrome://resources/html/action_link.html">
3 <link rel="import" href="chrome://resources/html/action_link_css.html"> 3 <link rel="import" href="chrome://resources/html/action_link_css.html">
4 <link rel="import" href="chrome://resources/html/cr.html"> 4 <link rel="import" href="chrome://resources/html/cr.html">
5 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 5 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
6 <link rel="import" href="search_engines_browser_proxy.html"> 6 <link rel="import" href="search_engines_browser_proxy.html">
7 <link rel="import" href="search_engine_dialog.html"> 7 <link rel="import" href="search_engine_dialog.html">
8 <link rel="import" href="search_engines_list.html"> 8 <link rel="import" href="search_engines_list.html">
9 <link rel="import" href="omnibox_extension_entry.html"> 9 <link rel="import" href="omnibox_extension_entry.html">
10 <link rel="import" href="../global_scroll_target_behavior.html"> 10 <link rel="import" href="../global_scroll_target_behavior.html">
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 $i18n{searchEnginesNoOtherEngines} 42 $i18n{searchEnginesNoOtherEngines}
43 </div> 43 </div>
44 <settings-search-engines-list id="otherEngines" engines="[[otherEngines]]" 44 <settings-search-engines-list id="otherEngines" engines="[[otherEngines]]"
45 hide-headers scroll-target="[[subpageScrollTarget]]"> 45 hide-headers scroll-target="[[subpageScrollTarget]]">
46 </settings-search-engines-list> 46 </settings-search-engines-list>
47 <template is="dom-if" if="[[showExtensionsList_]]"> 47 <template is="dom-if" if="[[showExtensionsList_]]">
48 <div class="settings-box first"> 48 <div class="settings-box first">
49 <h2>$i18n{searchEnginesExtension}</h2> 49 <h2>$i18n{searchEnginesExtension}</h2>
50 </div> 50 </div>
51 <iron-list id="extensions" class="extension-engines fixed-height-list" 51 <iron-list id="extensions" class="extension-engines fixed-height-list"
52 selectable items="[[extensions]]"> 52 items="[[extensions]]">
53 <template> 53 <template>
54 <settings-omnibox-extension-entry engine="[[item]]" 54 <settings-omnibox-extension-entry engine="[[item]]"
55 tabindex$="[[tabIndex]]"> 55 tabindex$="[[tabIndex]]" iron-list-tab-index="[[tabIndex]]"
hcarmona 2017/05/04 21:03:35 do you need both tabindex and iron-list-tab-index?
scottchen 2017/05/04 21:57:38 yeah, the js code uses them to do slightly differe
hcarmona 2017/05/04 22:51:35 SG
56 last-focused="{{OmniboxExtensionlastFocused_}}">
56 </settings-omnibox-extension-entry> 57 </settings-omnibox-extension-entry>
57 </template> 58 </template>
58 </iron-list> 59 </iron-list>
59 </template> 60 </template>
60 </template> 61 </template>
61 <script src="search_engines_page.js"></script> 62 <script src="search_engines_page.js"></script>
62 </dom-module> 63 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698