[LargeIconService] Add a unit-test for overriding request URL

[LargeIconService] Add a unit-test for overriding request URL

This CL adds a test for a feature added in CL 2839653002, merged to M59.
The test has been implemented along with the original CL but is uploaded
separately to speed up the process (avoiding deps changes).

BUG=705572
Review-Url: https://codereview.chromium.org/2852383002
Cr-Commit-Position: refs/heads/master@{#469385}
Committed: https://chromium.googlesource.com/chromium/src/+/cd7413fed73714316fa36d7db9979168cee46758

[jkrcal, 2017-05-02 14:14:59]

jkrcal@chromium.org changed reviewers:
+ asvitkine@chromium.org, pkotwicz@chromium.org

[jkrcal, 2017-05-02 14:15:00]

Peter, could you PTAL?

Alexei, could you PTAL at DEPS changes?
(maybe the VariationParamsManager could also sometimes get renamed and moved to
base along with the getters for field trial params?)

[Alexei Svitkine (slow), 2017-05-02 15:39:01]

lgtm

Moving that class to base/test sgtm.

[pkotwicz, 2017-05-03 17:35:20]

LGTM with nit

https://codereview.chromium.org/2852383002/diff/1/components/favicon/core/lar...
File components/favicon/core/large_icon_service_unittest.cc (right):

https://codereview.chromium.org/2852383002/diff/1/components/favicon/core/lar...
components/favicon/core/large_icon_service_unittest.cc:195:
"Favicons.LargeIconService.DownloadedSize", 64, /*expected_count=*/1);
Checking the histogram is unrelated to the main goal of the test?

[jkrcal, 2017-05-04 15:28:20]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 15:28:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 15:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 15:33:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jkrcal, 2017-05-04 15:37:39]

Thanks!

https://codereview.chromium.org/2852383002/diff/1/components/favicon/core/lar...
File components/favicon/core/large_icon_service_unittest.cc (right):

https://codereview.chromium.org/2852383002/diff/1/components/favicon/core/lar...
components/favicon/core/large_icon_service_unittest.cc:195:
"Favicons.LargeIconService.DownloadedSize", 64, /*expected_count=*/1);
On 2017/05/03 17:35:20, pkotwicz wrote:
> Checking the histogram is unrelated to the main goal of the test?

Correct, removed.

[jkrcal, 2017-05-04 15:38:42]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 15:38:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 17:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 17:28:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jkrcal, 2017-05-04 17:29:32]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2017-05-04 17:29:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2852383002/#ps40001
(title: "Fixing build")

[commit-bot: I haz the power, 2017-05-04 17:29:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 18:18:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493918972383840,
"parent_rev": "2961d5c4106bbc849631b956dcfb62a2c27db378", "commit_rev":
"cd7413fed73714316fa36d7db9979168cee46758"}

[commit-bot: I haz the power, 2017-05-04 18:18:32]

Description was changed from

==========
[LargeIconService] Add a unit-test for overriding request URL

This CL adds a test for a feature added in CL 2839653002, merged to M59.
The test has been implemented along with the original CL but is uploaded
separately to speed up the process (avoiding deps changes).

BUG=705572
==========

to

==========
[LargeIconService] Add a unit-test for overriding request URL

This CL adds a test for a feature added in CL 2839653002, merged to M59.
The test has been implemented along with the original CL but is uploaded
separately to speed up the process (avoiding deps changes).

BUG=705572

Review-Url: https://codereview.chromium.org/2852383002
Cr-Commit-Position: refs/heads/master@{#469385}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd7413fed73714316fa36d7db997...
==========

[commit-bot: I haz the power, 2017-05-04 18:18:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cd7413fed73714316fa36d7db997...