Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2013)

Unified Diff: content/public/test/render_view_test.cc

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)
Patch Set: CR-gab-12 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index e04ab92c730ea71ff925a9415a3d9207f1aed6e1..1afbb54c36991dd73b3a0f809e619d36c96e67f7 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -157,9 +157,7 @@ RenderViewTest::~RenderViewTest() {
}
void RenderViewTest::ProcessPendingMessages() {
sky 2017/05/04 02:58:55 How about removing this function entirely and havi
fdoray 2017/05/08 15:22:08 Done in a separate CL https://codereview.chromium.
- msg_loop_.task_runner()->PostTask(FROM_HERE,
- base::MessageLoop::QuitWhenIdleClosure());
- base::RunLoop().Run();
+ base::RunLoop().RunUntilIdle();
}
WebLocalFrame* RenderViewTest::GetMainFrame() {

Powered by Google App Engine
This is Rietveld 408576698