Rename SafeBrowsingErrorUI to SafeBrowsingLoudErrorUI

components/security_interstitials/core/base_safe_browsing_error_ui.cc

Index: components/security_interstitials/core/base_safe_browsing_error_ui.cc
diff --git a/components/security_interstitials/core/base_safe_browsing_error_ui.cc b/components/security_interstitials/core/base_safe_browsing_error_ui.cc
new file mode 100644
index 0000000000000000000000000000000000000000..648d2e4fdfec98963b6caa7e9df4ce10354e6d65
--- /dev/null
+++ b/components/security_interstitials/core/base_safe_browsing_error_ui.cc
@@ -0,0 +1,22 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/security_interstitials/core/base_safe_browsing_error_ui.h"
+
+namespace security_interstitials {
+
+BaseSafeBrowsingErrorUI::BaseSafeBrowsingErrorUI(
+    const GURL& request_url,
+    const GURL& main_frame_url,
+    BaseSafeBrowsingErrorUI::SBInterstitialReason reason,
+    const BaseSafeBrowsingErrorUI::SBErrorDisplayOptions& display_options,
+    const std::string& app_locale,
+    const base::Time& time_triggered,
+    ControllerClient* controller)
+    : interstitial_reason_(std::move(reason)),

[Jialiu Lin, 2017/05/08 18:51:16]

no need to use std::move() on interstitial_reasons_. it is a primitive type.

And no need to use std::move for display_options_ either, display_options is a
tiny object.

[edwardjung, 2017/05/08 20:43:00]

Done.

+      display_options_(std::move(display_options)){};

[Jialiu Lin, 2017/05/08 18:51:16]

request_url_, main_frame_url_, app_locale_, time_triggered_ and controller_ not
initialized in constructor. 


That's why crash happens wherever you call these uninitialized values.

[edwardjung, 2017/05/08 20:43:00]

Done.

+
+BaseSafeBrowsingErrorUI::~BaseSafeBrowsingErrorUI(){};
+
+}  // security_interstitials