components/security_interstitials/core/base_safe_browsing_error_ui.cc - Issue 2852333003: Rename SafeBrowsingErrorUI to SafeBrowsingLoudErrorUI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/security_interstitials/core/base_safe_browsing_error_ui.cc

Issue 2852333003: Rename SafeBrowsingErrorUI to SafeBrowsingLoudErrorUI (Closed)

Patch Set: Fix tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/security_interstitials/core/base_safe_browsing_error_ui.h ('k') | components/security_interstitials/core/safe_browsing_error_ui.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/security_interstitials/core/base_safe_browsing_error_ui.h"

	6

	7 namespace security_interstitials {

	8

	9 BaseSafeBrowsingErrorUI::BaseSafeBrowsingErrorUI(

	10 const GURL& request_url,

	11 const GURL& main_frame_url,

	12 BaseSafeBrowsingErrorUI::SBInterstitialReason reason,

	13 const BaseSafeBrowsingErrorUI::SBErrorDisplayOptions& display_options,

	14 const std::string& app_locale,

	15 const base::Time& time_triggered,

	16 ControllerClient* controller)

	17 : interstitial_reason_(std::move(reason)),
	Jialiu Lin 2017/05/08 18:51:16 no need to use std::move() on interstitial_reasons no need to use std::move() on interstitial_reasons_. it is a primitive type. And no need to use std::move for display_options_ either, display_options is a tiny object. edwardjung 2017/05/08 20:43:00 Done. Show quoted text On 2017/05/08 18:51:16, Jialiu Lin wrote: > no need to use std::move() on interstitial_reasons_. it is a primitive type. > > And no need to use std::move for display_options_ either, display_options is a > tiny object. Done.
	18 display_options_(std::move(display_options)){};
	Jialiu Lin 2017/05/08 18:51:16 request_url_, main_frame_url_, app_locale_, time_t request_url_, main_frame_url_, app_locale_, time_triggered_ and controller_ not initialized in constructor. That's why crash happens wherever you call these uninitialized values. edwardjung 2017/05/08 20:43:00 Done. Show quoted text On 2017/05/08 18:51:16, Jialiu Lin wrote: > request_url_, main_frame_url_, app_locale_, time_triggered_ and controller_ not > initialized in constructor. > > > That's why crash happens wherever you call these uninitialized values. Done.
	19

	20 BaseSafeBrowsingErrorUI::~BaseSafeBrowsingErrorUI(){};

	21

	22 } // security_interstitials

OLD	NEW