Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 285233008: Add MacAddress to ONC and networkingPrivate (Closed)

Created:
6 years, 7 months ago by stevenjb
Modified:
6 years, 7 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src
Visibility:
Public.

Description

Add MacAddress to ONC and networkingPrivate BUG=373965 For fake_wifi_service.cc R=armansito@chromium.org, pneubeck@chromium.org TBR=mef@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271679

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Feedback + test #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -40 lines) Patch
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 4 5 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/networking/test.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chromeos/network/device_state.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/network/device_state.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 1 2 3 4 chunks +13 lines, -6 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_util.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/network/network_util.cc View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_signature.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 2 3 3 chunks +15 lines, -2 lines 0 comments Download
M components/onc/docs/onc_spec.html View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M components/onc/onc_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/onc/onc_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/wifi/fake_wifi_service.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
stevenjb
6 years, 7 months ago (2014-05-15 22:55:17 UTC) #1
pneubeck (no reviews)
shouldn't this surface in some test? https://codereview.chromium.org/285233008/diff/40001/chromeos/network/onc/onc_translator_shill_to_onc.cc File chromeos/network/onc/onc_translator_shill_to_onc.cc (right): https://codereview.chromium.org/285233008/diff/40001/chromeos/network/onc/onc_translator_shill_to_onc.cc#newcode309 chromeos/network/onc/onc_translator_shill_to_onc.cc:309: // this property ...
6 years, 7 months ago (2014-05-16 07:44:54 UTC) #2
armansito
https://codereview.chromium.org/285233008/diff/40001/components/onc/docs/onc_spec.html File components/onc/docs/onc_spec.html (right): https://codereview.chromium.org/285233008/diff/40001/components/onc/docs/onc_spec.html#newcode400 components/onc/docs/onc_spec.html:400: networks. The format is 00:11:22:33:44:55. For digits greater than ...
6 years, 7 months ago (2014-05-16 15:54:12 UTC) #3
stevenjb
Added MacAddress to the getProperties test. https://codereview.chromium.org/285233008/diff/40001/chromeos/network/onc/onc_translator_shill_to_onc.cc File chromeos/network/onc/onc_translator_shill_to_onc.cc (right): https://codereview.chromium.org/285233008/diff/40001/chromeos/network/onc/onc_translator_shill_to_onc.cc#newcode309 chromeos/network/onc/onc_translator_shill_to_onc.cc:309: // this property ...
6 years, 7 months ago (2014-05-16 18:01:58 UTC) #4
armansito
lgtm
6 years, 7 months ago (2014-05-16 18:05:36 UTC) #5
pneubeck (no reviews)
lgtm
6 years, 7 months ago (2014-05-18 18:44:47 UTC) #6
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 7 months ago (2014-05-19 23:55:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/285233008/70001
6 years, 7 months ago (2014-05-19 23:56:16 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 03:16:31 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 03:19:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68551)
6 years, 7 months ago (2014-05-20 03:19:31 UTC) #11
stevenjb
6 years, 7 months ago (2014-05-20 17:23:20 UTC) #12
Message was sent while issue was closed. 
Committed patchset #6 manually as r271679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698