Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chromeos/network/onc/onc_translation_tables.cc

Issue 285233008: Add MacAddress to ONC and networkingPrivate (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_signature.cc ('k') | chromeos/network/onc/onc_translator_shill_to_onc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_translation_tables.cc
diff --git a/chromeos/network/onc/onc_translation_tables.cc b/chromeos/network/onc/onc_translation_tables.cc
index 820c177cb925c442c1424ef778a5d43154a8801f..b6fa1b0fcb5cf019365be031d1f85ecccf453027 100644
--- a/chromeos/network/onc/onc_translation_tables.cc
+++ b/chromeos/network/onc/onc_translation_tables.cc
@@ -162,20 +162,22 @@ const FieldTranslationEntry cellular_fields[] = {
{NULL}};
const FieldTranslationEntry network_fields[] = {
+ { ::onc::network_config::kGUID, shill::kGuidProperty},
+ { ::onc::network_config::kConnectable, shill::kConnectableProperty },
+ { ::onc::network_config::kErrorState, shill::kErrorProperty },
+
// Shill doesn't allow setting the name for non-VPN networks.
- // This field is conditionally translated, see onc_translator_*.
+ // Name is conditionally translated, see onc_translator_*.
// { ::onc::network_config::kName, shill::kNameProperty },
- { ::onc::network_config::kGUID, shill::kGuidProperty},
- // This field is converted during translation, see onc_translator_*.
+
+ // Type is converted during translation, see onc_translator_*.
// { ::onc::network_config::kType, shill::kTypeProperty },
- // This field is converted during translation, see
- // onc_translator_shill_to_onc.cc. It is only converted when going from
+ // These fields are converted during translation, see
+ // onc_translator_shill_to_onc.cc. They are only converted when going from
// Shill->ONC, and ignored otherwise.
// { ::onc::network_config::kConnectionState, shill::kStateProperty },
-
- { ::onc::network_config::kConnectable, shill::kConnectableProperty },
- { ::onc::network_config::kErrorState, shill::kErrorProperty },
+ // { ::onc::network_config::kMacAddress, shill::kAddressProperty },
{NULL}};
const FieldTranslationEntry ipconfig_fields[] = {
« no previous file with comments | « chromeos/network/onc/onc_signature.cc ('k') | chromeos/network/onc/onc_translator_shill_to_onc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698