Local NTP: Fade in the OneGoogleBar

Local NTP: Fade in the OneGoogleBar

BUG=583292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2852293002
Cr-Commit-Position: refs/heads/master@{#468633}
Committed: https://chromium.googlesource.com/chromium/src/+/73b7dd6283fbb92b031f6ce60ae2195b9ee9abba

[Marc Treib, 2017-05-02 10:37:22]

Description was changed from

==========
Local NTP: Fade in the OneGoogleBar

BUG=583292
==========

to

==========
Local NTP: Fade in the OneGoogleBar

BUG=583292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Marc Treib, 2017-05-02 10:37:25]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 10:37:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 11:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 11:32:05]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-05-02 11:32:13]

treib@chromium.org changed reviewers:
+ fhorschig@chromium.org

[Marc Treib, 2017-05-02 11:32:13]

PTAL!

[fhorschig, 2017-05-02 12:23:43]

lgtm with animation nit

https://codereview.chromium.org/2852293002/diff/1/chrome/browser/resources/lo...
File chrome/browser/resources/local_ntp/local_ntp.css (right):

https://codereview.chromium.org/2852293002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.css:289: transition: opacity 130ms;
Nit:
Is there any special reason why 130ms?
MD motions times would be 150ms-200ms for short/Desktop animations.

Same for easing. Some natural easing might be appropriate.
("ease-in" or "ease-out", not sure which is the right one here.)

https://material.io/guidelines/motion/duration-easing.html#duration-easing-na...

[Marc Treib, 2017-05-02 14:07:14]

On 2017/05/02 12:23:43, fhorschig wrote:
> lgtm with animation nit
> 
>
https://codereview.chromium.org/2852293002/diff/1/chrome/browser/resources/lo...
> File chrome/browser/resources/local_ntp/local_ntp.css (right):
> 
>
https://codereview.chromium.org/2852293002/diff/1/chrome/browser/resources/lo...
> chrome/browser/resources/local_ntp/local_ntp.css:289: transition: opacity
130ms;
> Nit:
> Is there any special reason why 130ms?
> MD motions times would be 150ms-200ms for short/Desktop animations.
> 
> Same for easing. Some natural easing might be appropriate.
> ("ease-in" or "ease-out", not sure which is the right one here.)
> 
>
https://material.io/guidelines/motion/duration-easing.html#duration-easing-na...

The 130ms are taken from the remote NTP - for now, I'm trying to keep UI
differences to a minimum. I agree that 130ms is very short; maybe we can address
this in a material-ification of the NTP soonish.
Also, I'm pretty sure that with 130ms, it's impossible to tell whether it's
ease-in or ease-out (but probably UXers would disagree with me :D).

Nice reference though!

[Marc Treib, 2017-05-02 14:52:37]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-05-02 14:52:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 14:57:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493736757754430, "parent_rev":
"6822b60b6967b700212972aefcceda3aad23785c", "commit_rev":
"73b7dd6283fbb92b031f6ce60ae2195b9ee9abba"}

[commit-bot: I haz the power, 2017-05-02 14:57:11]

Description was changed from

==========
Local NTP: Fade in the OneGoogleBar

BUG=583292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Local NTP: Fade in the OneGoogleBar

BUG=583292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2852293002
Cr-Commit-Position: refs/heads/master@{#468633}
Committed:
https://chromium.googlesource.com/chromium/src/+/73b7dd6283fbb92b031f6ce60ae2...
==========

[commit-bot: I haz the power, 2017-05-02 14:57:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73b7dd6283fbb92b031f6ce60ae2...