Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2852283002: [css-grid] Refactor the extent for baseline alignment computation (Closed)

Created:
3 years, 7 months ago by svillar
Modified:
3 years, 7 months ago
Reviewers:
jfernandez, Manuel Rego
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Refactor the extent for baseline alignment computation Title says it all, we were doing basically the same in two different methods of the track sizing algorithm. We use an optional as return value to tell the caller whether baseline alignment applies or not. Review-Url: https://codereview.chromium.org/2852283002 Cr-Commit-Position: refs/heads/master@{#468653} Committed: https://chromium.googlesource.com/chromium/src/+/73c6ed6036451a31ef2b47d12ece1ee652c1c6d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp View 3 chunks +20 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
svillar
3 years, 7 months ago (2017-05-02 09:36:33 UTC) #2
jfernandez
lgtm
3 years, 7 months ago (2017-05-02 14:23:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852283002/1
3 years, 7 months ago (2017-05-02 14:28:20 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:01:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73c6ed6036451a31ef2b47d12ece...

Powered by Google App Engine
This is Rietveld 408576698